From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FD0D10F; Mon, 20 Nov 2023 09:28:06 -0800 (PST) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SYvZB3s7mz6K9Kv; Tue, 21 Nov 2023 01:26:42 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 20 Nov 2023 17:28:03 +0000 Date: Mon, 20 Nov 2023 17:28:02 +0000 From: Jonathan Cameron To: Marek Vasut CC: Jonathan Cameron , , "Conor Dooley" , Alexander Stein , Andre Werner , Andy Shevchenko , Bjorn Helgaas , Conor Dooley , Fabio Estevam , Guenter Roeck , Krzysztof Kozlowski , Lars-Peter Clausen , Luca Ceresoli , Mark Brown , Matti Vaittinen , Naresh Solanki , Patrick Rudolph , Rob Herring , "Stefan Windfeldt-Prytz" , Vincent Tremblay , Subject: Re: [PATCH v2 1/2] dt-bindings: iio: light: isl76682: Document ISL76682 Message-ID: <20231120172802.00006f38@Huawei.com> In-Reply-To: <4fe94f10-ff06-417b-a6d5-433bfeeac641@denx.de> References: <20231118000614.186558-1-marex@denx.de> <20231119150756.20a023b5@jic23-huawei> <4fe94f10-ff06-417b-a6d5-433bfeeac641@denx.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected On Sun, 19 Nov 2023 19:08:45 +0100 Marek Vasut wrote: > On 11/19/23 16:07, Jonathan Cameron wrote: > > On Sat, 18 Nov 2023 01:06:09 +0100 > > Marek Vasut wrote: > > > >> The ISL76682 is very basic ALS which only supports ALS or IR mode > >> in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any > >> other fancy functionality. Document it as trivial device. > >> > >> Acked-by: Conor Dooley > >> Signed-off-by: Marek Vasut > > > > I'm always a bit in 2 minds about trivial-devices as it doesn't > > include a basic power supply. In this case vdd which I'd prefer > > to see documented even on such a simple device as this. > > Not everyone is going to leave it powered up all the time! > > > > Still I'm not that fussed. Maybe it's worth allowing vdd-supply in > > trivial-devices.yaml? > > The hardware I have is powered all the time, so I'd be adding completely > untested code which is no less useless for me (at least right now). Lets > postpone this until there is a need for it, can we ? It's untested but trivial code (one call and an error code check) but fair enough. Previous experience says that we'll soon see it added... Its probably the most common follow up patch for a new driver. > > I addressed all the other comments in 2/2. >