From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E4819A; Tue, 21 Nov 2023 06:42:49 -0800 (PST) Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-359d796abd6so16877355ab.0; Tue, 21 Nov 2023 06:42:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700577768; x=1701182568; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g3A7KpgHMK4Z79+I2bLwtyrRdlzJKFRe2k6m6RGdmok=; b=Q96eu84eiaewjJSbJlAY7hsa4u5TwC3G4eDGAU5Wr8YZ7WXgzDzPauZPasrdZ8rshm GZjR3iRVSergYzS9DchyCMWQYyJtXHfdKnIoGpBB2gQIR/l4z/98lVCJK2Kvy6IABKuZ kmm9vas/Jkd+tk9xSyaoxgRSlvmZyyNcb3AfHb2+j86/UToNEul5i59qqx1z4d0qUEJA +9AwOHyq5VomXShnuEGWk4z9GByrtA+XwLTxd2xLw8XZDDPRGJRGl5bqWXr/zmefB53x IVm3j4fdeQFVIqCm6Z02IeyfDikLkEReSGu2LZ38PHSmcr4GTplg77WVHURnGuirtTNo /d9A== X-Gm-Message-State: AOJu0YydLFaVkqDTWjpnhrRhPAdpTO6/o/mZfbfzkiL03L45TzXQs3tN U6nYBke9fbQPYcIOOVW5Iw== X-Google-Smtp-Source: AGHT+IFErelSnQ13ze33zj2Pn9ZJ8mT036wv+Q+uVkt2NH4z4GKcQqP9beqPCMRCJybBK/5ldhsxlw== X-Received: by 2002:a05:6e02:ef4:b0:35a:e585:4275 with SMTP id j20-20020a056e020ef400b0035ae5854275mr2441886ilk.7.1700577768236; Tue, 21 Nov 2023 06:42:48 -0800 (PST) Received: from herring.priv ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id s5-20020a056e0210c500b0035129b9c61bsm3232374ilj.45.2023.11.21.06.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 06:42:47 -0800 (PST) Received: (nullmailer pid 1689994 invoked by uid 1000); Tue, 21 Nov 2023 14:42:44 -0000 Date: Tue, 21 Nov 2023 07:42:44 -0700 From: Rob Herring To: Andrew Lunn Cc: Christian Marangi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heiner Kallweit , Russell King , Florian Fainelli , Broadcom internal kernel review list , Daniel Golle , Qingfang Deng , SkyLake Huang , Matthias Brugger , AngeloGioacchino Del Regno , David Epping , Vladimir Oltean , "Russell King (Oracle)" , Harini Katakam , Simon Horman , Robert Marko , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [net-next RFC PATCH 03/14] dt-bindings: net: document ethernet PHY package nodes Message-ID: <20231121144244.GA1682395-robh@kernel.org> References: <20231120135041.15259-1-ansuelsmth@gmail.com> <20231120135041.15259-4-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 20, 2023 at 09:44:58PM +0100, Andrew Lunn wrote: > On Mon, Nov 20, 2023 at 02:50:30PM +0100, Christian Marangi wrote: > > Document ethernet PHY package nodes used to describe PHY shipped in > > bundle of 4-5 PHY. These particular PHY require specific PHY in the > > package for global onfiguration of the PHY package. > > > > Example are PHY package that have some regs only in one PHY of the > > package and will affect every other PHY in the package, for example > > related to PHY interface mode calibration or global PHY mode selection. > > I think you are being overly narrow here. The 'global' registers could > be spread over multiple addresses. Particularly for a C22 PHY. I > suppose they could even be in a N+1 address space, where there is no > PHY at all. > > Where the global registers are is specific to a PHY package > vendor/model. For this reason in particular, the package needs a specific compatible. > The PHY driver should know this. All the PHY driver > needs to know is some sort of base offset. PHY0 in this package is > using address X. It can then use relative addressing from this base to > access the global registers for this package. > > > It's also possible to specify the property phy-mode to specify that the > > PHY package sets a global PHY interface mode and every PHY of the > > package requires to have the same PHY interface mode. > > I don't think it is what simple. See the QCA8084 for example. 3 of the > 4 PHYs must use QXGMII. The fourth PHY can also use QXGMII but it can > be multiplexed to a different PMA and use 1000BaseX, SGMII or > 2500BaseX. > > I do think we need somewhere to put package properties. But i don't > think phy-mode is such a property. At the moment, i don't have a good > example of a package property. What about power supplies and reset/enable lines? Rob