[PATCH v1] arm64: dts: k3-am625-verdin: enable Verdin UART2

[PATCH v1] arm64: dts: k3-am625-verdin: enable Verdin UART2

[Parth Pancholi]

From: Parth Pancholi <parth.pancholi@toradex.com>

Enable UART2 for AM62 based SOM's Verdin carrier boards Dahlia,
Development and Yavia.
Earlier Verdin UART2 was reserved by R5 DM firmware which can be now
configured using boardcfg during U-boot compilation in the latest TI
SDKs. In a default config, no one writes to this UART.

Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>

---

 arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi | 3 +--
 arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi    | 3 +--
 arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi  | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
index 013357d17d48..bf6d27e70bc4 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
@@ -214,6 +214,5 @@ &verdin_gpio_keys {
 
 /* Verdin UART_2 */
 &wkup_uart0 {
-	/* FIXME: WKUP UART0 is used by DM firmware */
-	status = "reserved";
+	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
index 6701cb8974bb..680071688dcb 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
@@ -235,6 +235,5 @@ &verdin_gpio_keys {
 
 /* Verdin UART_2 */
 &wkup_uart0 {
-	/* FIXME: WKUP UART0 is used by DM firmware */
-	status = "reserved";
+	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi
index c685df7deaee..997dfafd27eb 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi
@@ -207,6 +207,5 @@ &verdin_gpio_keys {
 
 /* Verdin UART_2 */
 &wkup_uart0 {
-	/* FIXME: WKUP UART0 is used by DM firmware */
-	status = "reserved";
+	status = "okay";
 };
-- 
2.34.1

Re: [PATCH v1] arm64: dts: k3-am625-verdin: enable Verdin UART2

[Nishanth Menon]

On 17:04-20231121, Parth Pancholi wrote:
> From: Parth Pancholi <parth.pancholi@toradex.com>
> 
> Enable UART2 for AM62 based SOM's Verdin carrier boards Dahlia,
> Development and Yavia.
> Earlier Verdin UART2 was reserved by R5 DM firmware which can be now
> configured using boardcfg during U-boot compilation in the latest TI
> SDKs. In a default config, no one writes to this UART.
> 
> Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
> 
> ---
> 
>  arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi | 3 +--
>  arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi    | 3 +--
>  arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi  | 3 +--
>  3 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
> index 013357d17d48..bf6d27e70bc4 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
> @@ -214,6 +214,5 @@ &verdin_gpio_keys {
>  
>  /* Verdin UART_2 */
>  &wkup_uart0 {
> -	/* FIXME: WKUP UART0 is used by DM firmware */
> -	status = "reserved";
> +	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
> index 6701cb8974bb..680071688dcb 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
> @@ -235,6 +235,5 @@ &verdin_gpio_keys {
>  
>  /* Verdin UART_2 */
>  &wkup_uart0 {
> -	/* FIXME: WKUP UART0 is used by DM firmware */
> -	status = "reserved";
> +	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi
> index c685df7deaee..997dfafd27eb 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-yavia.dtsi
> @@ -207,6 +207,5 @@ &verdin_gpio_keys {
>  
>  /* Verdin UART_2 */
>  &wkup_uart0 {
> -	/* FIXME: WKUP UART0 is used by DM firmware */
> -	status = "reserved";
> +	status = "okay";
>  };
> -- 
> 2.34.1
> 

Do the &pinctrl_wkup_uart0 in verdin.dtsi hold good through these
variants?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v1] arm64: dts: k3-am625-verdin: enable Verdin UART2

[Francesco Dolcini]

Hello Nishanth,

On Thu, Nov 23, 2023 at 01:12:35AM -0600, Nishanth Menon wrote:
> On 17:04-20231121, Parth Pancholi wrote:
> >  /* Verdin UART_2 */
> >  &wkup_uart0 {
> > -	/* FIXME: WKUP UART0 is used by DM firmware */
> > -	status = "reserved";
> > +	status = "okay";
> >  };
> > -- 
> > 2.34.1
> > 
> 
> Do the &pinctrl_wkup_uart0 in verdin.dtsi hold good through these
> variants?
Yes.

Let me add a little bit of context.

In general the way the Verdin AM62 (and Toradex SOM) is designed is that
we have a standard pinmuxing on the module edge connector (SODIMM) and
normally the carrier board that is mated with just implements it.
It's absolutely possible to redefine it all, but to maximize
compatibility across the family what we do at most is to reconfigure
some pins as GPIO.

Francesco

Re: [PATCH v1] arm64: dts: k3-am625-verdin: enable Verdin UART2

[Francesco Dolcini]

On Tue, Nov 21, 2023 at 05:04:36PM +0100, Parth Pancholi wrote:
> From: Parth Pancholi <parth.pancholi@toradex.com>
> 
> Enable UART2 for AM62 based SOM's Verdin carrier boards Dahlia,
> Development and Yavia.
> Earlier Verdin UART2 was reserved by R5 DM firmware which can be now
> configured using boardcfg during U-boot compilation in the latest TI
> SDKs. In a default config, no one writes to this UART.
> 
> Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Francesco

Re: [PATCH v1] arm64: dts: k3-am625-verdin: enable Verdin UART2

[Nishanth Menon]

Hi Parth Pancholi,

On Tue, 21 Nov 2023 17:04:36 +0100, Parth Pancholi wrote:
> Enable UART2 for AM62 based SOM's Verdin carrier boards Dahlia,
> Development and Yavia.
> Earlier Verdin UART2 was reserved by R5 DM firmware which can be now
> configured using boardcfg during U-boot compilation in the latest TI
> SDKs. In a default config, no one writes to this UART.
> 
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: k3-am625-verdin: enable Verdin UART2
      commit: 26e0124683c000c2a197204e0fdc68e553298bff

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D