From: Rob Herring <robh@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Conor Dooley <conor@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v2 1/4] kbuild: Move dtc graph_child_address warning to W=2
Date: Wed, 22 Nov 2023 15:12:32 -0700 [thread overview]
Message-ID: <20231122-dtc-warnings-v2-1-bd4087325392@kernel.org> (raw)
In-Reply-To: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org>
There are cases where having a single child node with a unit-address is
valid. For example, other child nodes may be optional or added via a
DT overlay. This hasn't mattered until now, but as platforms become
free of W=1 warnings, we want to enable W=1 by default on a per
platform basis. So move the warning to W=2.
In the process, the logic can be reworked a bit to avoid specifying a
given warning in multiple places.
Signed-off-by: Rob Herring <robh@kernel.org>
---
scripts/Makefile.lib | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 68d0134bdbf9..a67f781ae8ee 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -340,8 +340,6 @@ quiet_cmd_gzip = GZIP $@
# DTC
# ---------------------------------------------------------------------------
DTC ?= $(objtree)/scripts/dtc/dtc
-DTC_FLAGS += -Wno-interrupt_provider \
- -Wno-unique_unit_address
# Disable noisy checks by default
ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
@@ -357,9 +355,11 @@ endif
ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)
DTC_FLAGS += -Wnode_name_chars_strict \
- -Wproperty_name_chars_strict \
- -Winterrupt_provider \
- -Wunique_unit_address
+ -Wproperty_name_chars_strict
+else
+DTC_FLAGS += -Wno-interrupt_provider \
+ -Wno-unique_unit_address \
+ -Wno-graph_child_address
endif
DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
--
2.42.0
next prev parent reply other threads:[~2023-11-22 22:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 22:12 [PATCH v2 0/4] kbuild: Per arch/platform dtc warning levels Rob Herring
2023-11-22 22:12 ` Rob Herring [this message]
2023-11-22 22:12 ` [PATCH v2 2/4] kbuild: Allow arch/platform override of dtc warning level Rob Herring
2023-11-22 22:12 ` [PATCH v2 3/4] riscv: dts: Always enable extra W=1 warnings Rob Herring
2023-11-22 22:12 ` [PATCH v2 4/4] arm/arm64: dts: samsung: " Rob Herring
2023-11-23 7:18 ` Krzysztof Kozlowski
2023-11-23 7:38 ` [PATCH v2 0/4] kbuild: Per arch/platform dtc warning levels Masahiro Yamada
2023-11-23 9:43 ` Conor Dooley
2023-11-23 12:00 ` Masahiro Yamada
2023-11-27 14:03 ` Rob Herring
2023-11-28 12:02 ` Masahiro Yamada
2023-11-28 22:25 ` Rob Herring
2023-11-29 17:49 ` Masahiro Yamada
2023-11-23 9:47 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122-dtc-warnings-v2-1-bd4087325392@kernel.org \
--to=robh@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).