* [PATCH] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes
@ 2023-11-22 22:44 Rob Herring
2023-11-23 7:26 ` Krzysztof Kozlowski
2023-11-29 11:50 ` Philipp Zabel
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-11-22 22:44 UTC (permalink / raw)
To: Philipp Zabel, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: devicetree, linux-arm-kernel, linux-kernel
The compatible schema can be simplified to a single enum for all the cases
with "fsl,imx51-src" fallback compatible.
In addition, the compatible strings are redundantly quoted. Drop unneeded
quotes over simple string values to fix a soon to be enabled yamllint
warning:
[error] string value is redundantly quoted with any quotes (quoted-strings)
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/reset/fsl,imx-src.yaml | 31 ++++++-------------
1 file changed, 10 insertions(+), 21 deletions(-)
diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
index b11ac533f914..f5ec1d54aa51 100644
--- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
+++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
@@ -28,28 +28,17 @@ description: |
properties:
compatible:
oneOf:
- - const: "fsl,imx51-src"
+ - const: fsl,imx51-src
- items:
- - const: "fsl,imx50-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx53-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6q-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6sx-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6sl-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6ul-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6sll-src"
- - const: "fsl,imx51-src"
+ - enum:
+ - fsl,imx50-src
+ - fsl,imx53-src
+ - fsl,imx6q-src
+ - fsl,imx6sx-src
+ - fsl,imx6sl-src
+ - fsl,imx6ul-src
+ - fsl,imx6sll-src
+ - const: fsl,imx51-src
reg:
maxItems: 1
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes
2023-11-22 22:44 [PATCH] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes Rob Herring
@ 2023-11-23 7:26 ` Krzysztof Kozlowski
2023-11-29 11:50 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-23 7:26 UTC (permalink / raw)
To: Rob Herring, Philipp Zabel, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: devicetree, linux-arm-kernel, linux-kernel
On 22/11/2023 23:44, Rob Herring wrote:
> The compatible schema can be simplified to a single enum for all the cases
> with "fsl,imx51-src" fallback compatible.
>
> In addition, the compatible strings are redundantly quoted. Drop unneeded
> quotes over simple string values to fix a soon to be enabled yamllint
> warning:
>
> [error] string value is redundantly quoted with any quotes (quoted-strings)
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes
2023-11-22 22:44 [PATCH] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes Rob Herring
2023-11-23 7:26 ` Krzysztof Kozlowski
@ 2023-11-29 11:50 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2023-11-29 11:50 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel
On Wed, 22 Nov 2023 15:44:04 -0700, Rob Herring wrote:
> The compatible schema can be simplified to a single enum for all the cases
> with "fsl,imx51-src" fallback compatible.
>
> In addition, the compatible strings are redundantly quoted. Drop unneeded
> quotes over simple string values to fix a soon to be enabled yamllint
> warning:
>
> [...]
Applied to reset/next, thanks!
[1/1] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes
https://git.pengutronix.de/cgit/pza/linux/commit/?id=e4916e791fb6
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-29 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-22 22:44 [PATCH] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes Rob Herring
2023-11-23 7:26 ` Krzysztof Kozlowski
2023-11-29 11:50 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).