Re: [PATCH v2 1/2] dt-bindings: hwmon: Add LTC4282 bindings

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

On Fri, Nov 24, 2023 at 03:18:16PM +0100, Nuno Sa via B4 Relay wrote:

> +  adi,gpio1-mode:
> +    description: Defines the function of the Pin.
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [gpio, power_bad, power_good]
> +
> +  adi,gpio2-mode:
> +    description: Defines the function of the Pin.
> +          0 - GPIO Mode.
> +          1 - Acts as an input pin and it is feeded into the ADC.
> +          2 - Pulls Low when the MOSFET is dissipating power (stress).

These three descriptions here probably need to be updated, one for being
too short and these two for still having the integer stuff in the
descriptions. Otherwise I think this is looking okay.

Cheers,
Conor.

> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [gpio, adc_input, stress_fet]
> +
> +  adi,gpio3-mode:
> +    description: Defines the function of the Pin.
> +          0 - GPIO Mode.
> +          1 - Acts as an input pin and it is feeded into the ADC.
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [gpio, adc_input]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]