From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB0B7E560; Sat, 25 Nov 2023 12:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tjJVHMw5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0756C433C7; Sat, 25 Nov 2023 12:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700914374; bh=HaPs6rO9d02viq7dWMbdaoM03RBF1QX65JlhKX2KKcQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tjJVHMw53dN8MvofGbFCvqRLyBp8d4KD3v9p3MR2ir5f2sqPK/Yi2pCsrlUXUqEU1 PZsoI54sw3oatvY01aMh71m2kgvNQ/tSD64kB3wt2ShKlQIaIrMzY3bFNnShrs5M1A br965+pL9uE44PkwUOr1gFvNbrHDJXR7lXdKAgK4+sZxZGZ4vBl48tPHGkL/JMzgmP rtom8SJ1Af1Cs9BedYeDJubTAB6jQFpp+HkKpEM479SNzc8JsMH2gr/dDCeAfECyMI ZyhsXzMePWmUzIipB7kJ23N5gbryxnE6h2VagHBIa0Ox5bNdowsWeUl1bMwmIoY51E JNf5JYCYE8N0w== Date: Sat, 25 Nov 2023 12:12:45 +0000 From: Jonathan Cameron To: Anshul Dalal Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Conor Dooley , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v4 2/3] dt-bindings: iio: chemical: add aosong,ags02ma Message-ID: <20231125121245.6664470d@jic23-huawei> In-Reply-To: <20231125100139.193584-2-anshulusr@gmail.com> References: <20231125100139.193584-1-anshulusr@gmail.com> <20231125100139.193584-2-anshulusr@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 25 Nov 2023 15:31:37 +0530 Anshul Dalal wrote: > Add bindings for Aosong AGS02MA TVOC sensor. > > The sensor communicates over i2c with the default address 0x1a. > TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. > > Datasheet: > https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > Product-Page: > http://www.aosong.com/m/en/products-33.html > > Signed-off-by: Anshul Dalal > --- > > Changes for v4: > - Changed node name from 'light-sensor' to 'voc-sensor' > > v3: https://lore.kernel.org/lkml/20231121095800.2180870-2-anshulusr@gmail.com/ > > Changes for v3: > - Fixed commit message > - Removed "asair,ags02ma" compatible > > v2: https://lore.kernel.org/lkml/20231115125810.1394854-2-anshulusr@gmail.com/ > > Changes for v2: > - Removed device from trivial-devices > - Added standalone binding with vdd-supply property > > v1: https://lore.kernel.org/lkml/20231107173100.62715-2-anshulusr@gmail.com/ > --- > .../bindings/iio/chemical/aosong,ags02ma.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > > diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > new file mode 100644 > index 000000000000..c176a6e102ac > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aosong AGS02MA VOC Sensor > + > +description: | > + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default > + address of 0x1a. > + > + Datasheet: > + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > + > +maintainers: > + - Anshul Dalal > + > +properties: > + compatible: > + enum: > + - aosong,ags02ma > + > + reg: > + maxItems: 1 > + > + vdd-supply: true Similar to other review (I put more background there) Convention these days at least is to always require powersupplies that the device cannot work with out (even if you can use a fixed supply and rely on the regulator framework papering over that). We want to distinguish generally optional supplies from ones we might not specify in a given DT. Jonathan > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + voc-sensor@1a { > + compatible = "aosong,ags02ma"; > + reg = <0x1a>; > + vdd-supply = <&vdd_regulator>; > + }; > + };