From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9FF0B65C; Sat, 25 Nov 2023 16:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XK82r4cp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42535C433C7; Sat, 25 Nov 2023 16:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700928493; bh=+JdvZzFz1fUXLr7nCkndqXtxJjfFTBUCZxGIR3myW/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XK82r4cpxnh9hdFs2xGKa0X1tALGw0LxQ1t2THSEhxqG76NMMrS5TELZ2Y7cjfUz1 9x0nQUCp9Gbx4GA2D7xj5X5s2tLvIM9oelKKTxWMFlDOMW+CeVcEhPYFcwkn94DRAE 1ebETkgDslvfycoGPAlUPjmlH8+XVd90RSJYwBW4mRiomWagnPqgOpMWexMGeWsuh/ jQ4SU/Oqbq6i8U5NmgP9ohB2ENdhhxjH6sUnlmJT3snaU8DY1kjbfjxgrDQdmaF2gI FMRXp9V1EXuAHYb6g+EAB8u0TsMRk6R/rA9JrP3l3ZOvcTmnyF9fuQkpEUVUpgv899 ZFZ4wf0DLKpIw== Date: Sat, 25 Nov 2023 16:08:04 +0000 From: Jonathan Cameron To: Marcelo Schmitt Cc: , , , , , , , , , , Subject: Re: [PATCH v2 0/7] Add support for AD7091R-2/-4/-8 Message-ID: <20231125160804.63c30be9@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 23 Nov 2023 13:29:12 -0300 Marcelo Schmitt wrote: > From: Marcelo Schmitt > > This series adds support for AD7091R-2/-4/-8 ADCs which can do single shot > or sequenced readings. Threshold events are also supported. > Overall, AD7091R-2/-4/-8 are very similar to AD7091R-5 except they use SPI interface. > > This has been tested with raspberrypi and eval board on kernel 6.1 from ADI fork. > Link: https://wiki.analog.com/resources/tools-software/linux-drivers/iio-adc/ad7091r8 > > I ran get_maintainers on driver files but completely forgot to run it on the > yaml doc, my bad. > I made the changes requested so far. > For v2, I also ran dt_binding_check on iio testing branch to check out for any > additional dt-schema issues. None reported. > Didn't see any other warn after running Sparse, Smatch, and Coccicheck. > I get a warn from checkpatch about IIO_DMA_MINALIGN which I don't know how to fix :( Fix checkpatch :) It has some exclusions for some of the warnings so probably look at what was added to avoid issues with __cacheline_aligned and friends. https://elixir.bootlin.com/linux/latest/source/scripts/checkpatch.pl#L515 > > Change log v1 -> v2: > - Added device tree related To/Cc recipients. > - Removed extra print of error code > - $ref: "adc.yaml" -> $ref: adc.yaml > - Fixed defined but not used build warn > - Moved dt documentation of required properties to after patternProperties. > - Removed incorrect return before regmap_update_bits(). > > Marcelo Schmitt (7): > iio: adc: ad7091r-base: Set alert config and drvdata > MAINTAINERS: Add MAINTAINERS entry for AD7091R > iio: adc: ad7091r: Move defines to header file > iio: adc: ad7091r: Alloc IIO device before generic probe > dt-bindings: iio: Add binding documentation for AD7091R-8 > iio: adc: Add support for AD7091R-8 > iio: adc: ad7091r-base: Add debugfs reg access > > .../bindings/iio/adc/adi,ad7091r8.yaml | 101 +++++++ > MAINTAINERS | 12 + > drivers/iio/adc/Kconfig | 16 ++ > drivers/iio/adc/Makefile | 4 +- > drivers/iio/adc/ad7091r-base.c | 114 +++++--- > drivers/iio/adc/ad7091r-base.h | 64 ++++- > drivers/iio/adc/ad7091r5.c | 55 ++-- > drivers/iio/adc/ad7091r8.c | 270 ++++++++++++++++++ > 8 files changed, 549 insertions(+), 87 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7091r8.yaml > create mode 100644 drivers/iio/adc/ad7091r8.c >