From: Jonathan Cameron <jic23@kernel.org>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>
Cc: <paul.cercueil@analog.com>, <Michael.Hennerich@analog.com>,
<lars@metafoo.de>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<marcelo.schmitt1@gmail.com>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/7] iio: adc: ad7091r: Alloc IIO device before generic probe
Date: Sat, 25 Nov 2023 16:21:55 +0000 [thread overview]
Message-ID: <20231125162155.2a3f980f@jic23-huawei> (raw)
In-Reply-To: <0a648afb9a06471380a7993b20cb44a9026c8248.1700751907.git.marcelo.schmitt1@gmail.com>
On Thu, 23 Nov 2023 13:41:59 -0300
Marcelo Schmitt <marcelo.schmitt@analog.com> wrote:
> Rework ad7091r probe functions so the IIO device is allocated before
> the generic device probe function is called.
> This change is needed for a follow up patch that passes a pointer to the
> IIO device to a couple of regmap callback functions.
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Why the gmail sign off? That's unusual enough that if it makes sense I'd like
to see a comment below the --- on why.
Patch is fine, though I'll need to read further for why this is needed!
Jonathan
next prev parent reply other threads:[~2023-11-25 16:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 16:29 [PATCH v2 0/7] Add support for AD7091R-2/-4/-8 Marcelo Schmitt
2023-11-23 16:40 ` [PATCH v2 1/7] iio: adc: ad7091r-base: Set alert config and drvdata Marcelo Schmitt
2023-11-25 16:13 ` Jonathan Cameron
2023-11-23 16:40 ` [PATCH v2 2/7] MAINTAINERS: Add MAINTAINERS entry for AD7091R Marcelo Schmitt
2023-11-25 16:15 ` Jonathan Cameron
2023-11-23 16:41 ` [PATCH v2 3/7] iio: adc: ad7091r: Move defines to header file Marcelo Schmitt
2023-11-25 16:18 ` Jonathan Cameron
2023-11-23 16:41 ` [PATCH v2 4/7] iio: adc: ad7091r: Alloc IIO device before generic probe Marcelo Schmitt
2023-11-25 16:21 ` Jonathan Cameron [this message]
2023-11-23 16:42 ` [PATCH v2 5/7] dt-bindings: iio: Add binding documentation for AD7091R-8 Marcelo Schmitt
2023-11-25 12:21 ` Conor Dooley
2023-11-27 20:53 ` Rob Herring
2023-11-23 16:42 ` [PATCH v2 6/7] iio: adc: Add support " Marcelo Schmitt
2023-11-25 16:41 ` Jonathan Cameron
2023-11-23 16:43 ` [PATCH v2 7/7] iio: adc: ad7091r-base: Add debugfs reg access Marcelo Schmitt
2023-11-25 16:44 ` Jonathan Cameron
2023-11-25 16:08 ` [PATCH v2 0/7] Add support for AD7091R-2/-4/-8 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231125162155.2a3f980f@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=paul.cercueil@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).