Re: [PATCH v2 1/2] dt-bindings: clock: versal: Make alt_ref optional

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2849 bytes --]

On Mon, Nov 27, 2023 at 12:52:03PM +0530, Shubhrajyoti Datta wrote:
> The alt_ref is present only in Versal-net devices.
> Other versal devices do not have it. Update the binding
> accordingly.

$subject is not accurate btw, "alt_ref" is not an option, its not
present on !versal-net devices. Could you rephrase that please?

Thanks,
Conor.

> 
> Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver")
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> 
> ---
> 
> Changes in v2:
> - Have specific constraints for versal and versal net.
> 
>  .../bindings/clock/xlnx,versal-clk.yaml       | 31 +++++++++++++++----
>  1 file changed, 25 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> index 1ba687d433b1..bef109d163a8 100644
> --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> @@ -31,11 +31,11 @@ properties:
>    clocks:
>      description: List of clock specifiers which are external input
>        clocks to the given clock controller.
> -    minItems: 3
> +    minItems: 2
>      maxItems: 8
>  
>    clock-names:
> -    minItems: 3
> +    minItems: 2
>      maxItems: 8
>  
>  required:
> @@ -59,15 +59,34 @@ allOf:
>          clocks:
>            items:
>              - description: reference clock
> -            - description: alternate reference clock
>              - description: alternate reference clock for programmable logic
>  
>          clock-names:
>            items:
>              - const: ref
> -            - const: alt_ref
>              - const: pl_alt_ref
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - xlnx,versal-net-clk
> +
> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: reference clock
> +            - description: alternate reference clock for programmable logic
> +            - description: alternate reference clock
> +
> +        clock-names:
> +          items:
> +            - const: ref
> +            - const: pl_alt_ref
> +            - const: alt_ref
> +
>    - if:
>        properties:
>          compatible:
> @@ -110,8 +129,8 @@ examples:
>          versal_clk: clock-controller {
>            #clock-cells = <1>;
>            compatible = "xlnx,versal-clk";
> -          clocks = <&ref>, <&alt_ref>, <&pl_alt_ref>;
> -          clock-names = "ref", "alt_ref", "pl_alt_ref";
> +          clocks = <&ref>,  <&pl_alt_ref>;
> +          clock-names = "ref", "pl_alt_ref";
>          };
>        };
>      };
> -- 
> 2.17.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]