From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36F4D26AC3 for ; Mon, 27 Nov 2023 17:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U077nLMr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F713C433C7; Mon, 27 Nov 2023 17:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701106271; bh=1f6++Sut+qyUgzlRDFrOoLD82uHFLjkr49VW132tP6g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U077nLMrvZvoNfq8uUMQhgonYGE3ddOcfxi7Oz/sLdbF18qsYWLQLFjftP6jN8Btv NprKf48THKk98Xs46KXuWhcfEw7Lp8xc4YBB7RwIgU82YueDzfLQQRJs1/hH4oZX+n vKbqvlaA+wa2wFQ7Ns6gjRwqD53NR2vnbUotSr8VensCvo/k7X45B6C3zBMu9xLHKQ qtzGPFlTDEFiy6icdg/JYxCMoI2k4Lp4DjM8Wu1EPcFPcjQCLUNOjqLkq0Hw9h4NjE UfeNo05hPz19oU7krzwKDN4ww8/QWEwBoECOHZ20OcNJvIViKljUN+IACnDwWx0X7c yqP87R/FNUUDg== Date: Mon, 27 Nov 2023 17:31:05 +0000 From: Conor Dooley To: Roland Hieber Cc: Marek Vasut , Stefan Agner , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liu Ying , Krzysztof Kozlowski , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Philipp Zabel Subject: Re: [PATCH] dt-bindings: mxsfb: Remove power-domains requirements for i.MX7D Message-ID: <20231127-education-skilled-9814c6fe4998@spud> References: <20231127-b4-dt-bindings-mxsfb-v1-1-922e4e71c838@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eRsFMvFDjL10ksWa" Content-Disposition: inline In-Reply-To: <20231127-b4-dt-bindings-mxsfb-v1-1-922e4e71c838@pengutronix.de> --eRsFMvFDjL10ksWa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 27, 2023 at 04:35:56PM +0100, Roland Hieber wrote: > From: Philipp Zabel >=20 > i.MX7D is documented as compatible with i.MX6SX, but it doesn't have the > power-domain requirement. Limit the i.MX6SX power-domains requirement to > i.MX6SX only. I dont like this commit message tbh, I shouldn't have to go and dig out the file to be able to understand what you are doing here - it should really be explained that the imx7d falls back to the imx6sx, as otherwise this looks like nothing at all to do with with imx7d. Thanks, Conor. >=20 > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL= power-domains property") > Signed-off-by: Philipp Zabel > Signed-off-by: Roland Hieber > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/D= ocumentation/devicetree/bindings/display/fsl,lcdif.yaml > index fc11ab5fc465..83532959e51c 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -117,13 +117,19 @@ allOf: > maxItems: 1 > clock-names: > maxItems: 1 > + - if: > + properties: > + compatible: > + const: fsl,imx6sx-lcdif > + then: > + required: > + - power-domains > - if: > properties: > compatible: > contains: > enum: > - fsl,imx6sl-lcdif > - - fsl,imx6sx-lcdif > - fsl,imx8mm-lcdif > - fsl,imx8mn-lcdif > - fsl,imx8mp-lcdif >=20 > --- > base-commit: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab > change-id: 20231127-b4-dt-bindings-mxsfb-9a0676d08b4c >=20 > Best regards, > --=20 > Roland Hieber, Pengutronix e.K. | rhi@pengutronix.de | > Steuerwalder Str. 21 | https://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >=20 >=20 --eRsFMvFDjL10ksWa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWTSWQAKCRB4tDGHoIJi 0h6OAQCM77zuKX5T/URD5xbri5KHdxypFWxTlRPjFWgoKcyH+AEAntIf1h5TsGP7 2ZsAPySWu/fjFf5kS+R8djJIA1Vppg0= =Dmgj -----END PGP SIGNATURE----- --eRsFMvFDjL10ksWa--