devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	git@amd.com, mturquette@baylibre.com, sboyd@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, michal.simek@amd.com
Subject: Re: [PATCH v2 2/2] dt-bindings: firmware: Remove alt_ref from versal example
Date: Mon, 27 Nov 2023 17:37:26 +0000	[thread overview]
Message-ID: <20231127-linguist-fog-4d88fc8a1bd4@spud> (raw)
In-Reply-To: <20231127072204.25879-3-shubhrajyoti.datta@amd.com>

[-- Attachment #1: Type: text/plain, Size: 1395 bytes --]

On Mon, Nov 27, 2023 at 12:52:04PM +0530, Shubhrajyoti Datta wrote:
> In the previous commit (dt-bindings: clock: versal: Make alt_ref
> optional) the alt_ref is removed from the veral-clk. Update the example
> accordingly.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>

TBH, I'd rather you squashed this into patch one than introduced a
warning in one patch, only to remove it in another.

> ---
> 
> Changes in v2:
> new patch addition
> 
>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml        | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> index 822864488dcb..8e584857ddd4 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> @@ -95,8 +95,8 @@ examples:
>        versal_clk: clock-controller {
>          #clock-cells = <1>;
>          compatible = "xlnx,versal-clk";
> -        clocks = <&ref>, <&alt_ref>, <&pl_alt_ref>;
> -        clock-names = "ref", "alt_ref", "pl_alt_ref";
> +        clocks = <&ref>, <&pl_alt_ref>;
> +        clock-names = "ref", "pl_alt_ref";
>        };
>      };
>  
> -- 
> 2.17.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2023-11-27 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27  7:22 [PATCH v2 0/2] dt-bindings: Remove alt_ref for versal Shubhrajyoti Datta
2023-11-27  7:22 ` [PATCH v2 1/2] dt-bindings: clock: versal: Make alt_ref optional Shubhrajyoti Datta
2023-11-27 17:39   ` Conor Dooley
2023-11-27 21:20   ` Rob Herring
2023-11-27  7:22 ` [PATCH v2 2/2] dt-bindings: firmware: Remove alt_ref from versal example Shubhrajyoti Datta
2023-11-27 17:37   ` Conor Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231127-linguist-fog-4d88fc8a1bd4@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shubhrajyoti.datta@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).