RE: [EXT] Re: [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX95 compatible

Xu Yang
2023-12-01T06:42:02Z

Hi Conor,

>
> On Mon, Nov 27, 2023 at 03:32:06PM +0800, Xu Yang wrote:
> > i.MX95 has a more precise counting capability than i.MX93. This will add
> > a compatible for it.
>
> It is hard to tell from this comment, but I figure this "more precise
> capability" is not an option you can enable, but instead makes the
> programming model of this device different to that of the imx93?

Actually, imx95 is compatible with imx93 except AXI ID filter capability.
But for AXI ID filter, imx95 is using different registers and bits from
imx93 for filter configuration. To distinguish them, I need use different
compatible because programming model cannot recognize which device is
running.

compatible = "fsl,imx95-ddr-pmu";
compatible = "fsl,imx95-ddr-pmu", "fsl,imx93-ddr-pmu";

Both above compatible is okay for me. Therefore, "fsl,imx95-ddr-pmu" is needed.

Thanks,
Xu Yang

>
> Thanks,
> Conor.
>
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > ---
> > Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml b/Documentation/devicetree/bindings/perf/fsl-
> imx-ddr.yaml
> > index e9fad4b3de68..1bc7bf1c8368 100644
> > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> > @@ -20,6 +20,7 @@ properties:
> > - fsl,imx8mn-ddr-pmu
> > - fsl,imx8mp-ddr-pmu
> > - fsl,imx93-ddr-pmu
> > + - fsl,imx95-ddr-pmu
> > - items:
> > - enum:
> > - fsl,imx8mm-ddr-pmu
> > --
> > 2.34.1
> >