* [PATCH] ARM: dts: rockchip: Fix sdmmc_pwren's pinmux setting for RK3128
@ 2023-11-27 18:46 Alex Bee
2023-11-28 9:58 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bee @ 2023-11-27 18:46 UTC (permalink / raw)
To: Heiko Stuebner, Conor Dooley, Krzysztof Kozlowski, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Alex Bee
RK3128's reference design uses sdmmc_pwren pincontrol as GPIO - see [0].
Let's change it in the SoC DT as well.
[0] https://github.com/rockchip-linux/kernel/commit/8c62deaf6025
Fixes: a0201bff6259 ("ARM: dts: rockchip: add rk3128 soc dtsi")
Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
This should have been part of my XPI-3128 board submission - it uses this
pin as GPIO and adapts the reference design in this regard.
Originally I had this as an override in the board DT, but later noticed
this relatively new commit in vendor's kernel. I simply forgot to add
that commit.
arch/arm/boot/dts/rockchip/rk3128.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rockchip/rk3128.dtsi b/arch/arm/boot/dts/rockchip/rk3128.dtsi
index 4e8b38604ecd..b16786e81c08 100644
--- a/arch/arm/boot/dts/rockchip/rk3128.dtsi
+++ b/arch/arm/boot/dts/rockchip/rk3128.dtsi
@@ -859,7 +859,7 @@ sdmmc_wp: sdmmc-wp {
};
sdmmc_pwren: sdmmc-pwren {
- rockchip,pins = <1 RK_PB6 1 &pcfg_pull_default>;
+ rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_default>;
};
sdmmc_bus4: sdmmc-bus4 {
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Fix sdmmc_pwren's pinmux setting for RK3128
2023-11-27 18:46 [PATCH] ARM: dts: rockchip: Fix sdmmc_pwren's pinmux setting for RK3128 Alex Bee
@ 2023-11-28 9:58 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2023-11-28 9:58 UTC (permalink / raw)
To: Alex Bee, Rob Herring, Conor Dooley, Krzysztof Kozlowski
Cc: Heiko Stuebner, linux-rockchip, devicetree, linux-kernel,
linux-arm-kernel
On Mon, 27 Nov 2023 19:46:44 +0100, Alex Bee wrote:
> RK3128's reference design uses sdmmc_pwren pincontrol as GPIO - see [0].
>
> Let's change it in the SoC DT as well.
>
> [0] https://github.com/rockchip-linux/kernel/commit/8c62deaf6025
>
>
> [...]
Applied, thanks!
[1/1] ARM: dts: rockchip: Fix sdmmc_pwren's pinmux setting for RK3128
commit: 0c349b5001f8bdcead844484c15a0c4dfb341157
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-28 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-27 18:46 [PATCH] ARM: dts: rockchip: Fix sdmmc_pwren's pinmux setting for RK3128 Alex Bee
2023-11-28 9:58 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).