From: Rob Herring <robh@kernel.org>
To: Tomas Paukrt <tomaspaukrt@email.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: serial: Add support for enabling RS485 mode via GPIO at boot time
Date: Mon, 27 Nov 2023 14:01:23 -0600 [thread overview]
Message-ID: <20231127200123.GA2896702-robh@kernel.org> (raw)
In-Reply-To: <3Zb.ZZsn.wkax8K4so6.1bN6eS@seznam.cz>
On Tue, Nov 21, 2023 at 09:28:12AM +0100, Tomas Paukrt wrote:
> Add an option to enable the RS485 mode at boot time based on
> the state of a GPIO pin (DIP switch or configuration jumper).
> The GPIO is defined by the device tree property "linux,rs485-mode-gpio".
>
> Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>
> ---
> Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml
> index 9418fd6..7a72f37 100644
> --- a/Documentation/devicetree/bindings/serial/rs485.yaml
> +++ b/Documentation/devicetree/bindings/serial/rs485.yaml
> @@ -47,6 +47,10 @@ properties:
> later with proper ioctl.
> $ref: /schemas/types.yaml#/definitions/flag
>
> + linux,rs485-mode-gpio:
This has little to do with Linux, so no need for linux prefix.
The preferred form is always plural '-gpios'.
> + description: GPIO pin to enable RS485 mode at boot time.
> + maxItems: 1
> +
> rs485-rx-during-tx:
> description: enables the receiving of data even while sending data.
> $ref: /schemas/types.yaml#/definitions/flag
> --
> 2.7.4
>
prev parent reply other threads:[~2023-11-27 20:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 8:28 [PATCH v4 2/2] dt-bindings: serial: Add support for enabling RS485 mode via GPIO at boot time Tomas Paukrt
2023-11-27 20:01 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127200123.GA2896702-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tomaspaukrt@email.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).