From: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
To: Wolfram Sang <wsa@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephan Gerhold <stephan.gerhold@kernkonzept.com>
Subject: [PATCH 1/3] dt-bindings: i2c: qcom,i2c-qup: Document power-domains
Date: Tue, 28 Nov 2023 10:48:35 +0100 [thread overview]
Message-ID: <20231128-i2c-qup-dvfs-v1-1-59a0e3039111@kernkonzept.com> (raw)
In-Reply-To: <20231128-i2c-qup-dvfs-v1-0-59a0e3039111@kernkonzept.com>
Similar to qcom,geni-i2c, for i2c-qup we need to vote for performance
states on the VDDCX power domain to ensure that required clock rates
can be generated correctly.
I2C is typically used with a fixed clock rate, so a single required-opp
is sufficient without a full OPP table (unlike spi-qup for example).
Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
---
Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml
index f43947514d48..fc3077a7af0d 100644
--- a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml
+++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml
@@ -52,9 +52,15 @@ properties:
- const: default
- const: sleep
+ power-domains:
+ maxItems: 1
+
reg:
maxItems: 1
+ required-opps:
+ maxItems: 1
+
required:
- compatible
- clock-names
@@ -68,6 +74,7 @@ examples:
- |
#include <dt-bindings/clock/qcom,gcc-msm8998.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
i2c@c175000 {
compatible = "qcom,i2c-qup-v2.2.1";
@@ -82,6 +89,8 @@ examples:
pinctrl-names = "default", "sleep";
pinctrl-0 = <&blsp1_i2c1_default>;
pinctrl-1 = <&blsp1_i2c1_sleep>;
+ power-domains = <&rpmpd MSM8909_VDDCX>;
+ required-opps = <&rpmpd_opp_svs_krait>;
clock-frequency = <400000>;
#address-cells = <1>;
--
2.39.2
next prev parent reply other threads:[~2023-11-28 9:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 9:48 [PATCH 0/3] i2c: qup: Allow scaling power domains and interconnect Stephan Gerhold
2023-11-28 9:48 ` Stephan Gerhold [this message]
2023-11-28 17:50 ` [PATCH 1/3] dt-bindings: i2c: qcom,i2c-qup: Document power-domains Rob Herring
2023-11-28 9:48 ` [PATCH 2/3] dt-bindings: i2c: qup: Document interconnects Stephan Gerhold
2023-11-28 17:51 ` Rob Herring
2023-11-28 9:48 ` [PATCH 3/3] i2c: qup: Vote for interconnect bandwidth to DRAM Stephan Gerhold
2023-11-28 19:17 ` Andi Shyti
2025-02-18 23:02 ` Andi Shyti
2025-02-18 23:13 ` Andi Shyti
2025-02-19 7:00 ` Krzysztof Kozlowski
2025-02-19 19:36 ` Andi Shyti
2025-02-19 10:40 ` Stephan Gerhold
2025-02-19 19:30 ` Andi Shyti
2025-02-20 9:47 ` Stephan Gerhold
2025-02-25 13:25 ` Konrad Dybcio
2025-02-26 22:11 ` [PATCH 0/3] i2c: qup: Allow scaling power domains and interconnect Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128-i2c-qup-dvfs-v1-1-59a0e3039111@kernkonzept.com \
--to=stephan.gerhold@kernkonzept.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).