From: Tony Lindgren <tony@atomide.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andreas Kemnade <andreas@kemnade.info>,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
kristo@kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: ti: Convert interface.txt to json-schema
Date: Tue, 28 Nov 2023 12:43:10 +0200 [thread overview]
Message-ID: <20231128104310.GS5169@atomide.com> (raw)
In-Reply-To: <7361082a-f271-4ef4-9dad-06ee7445c749@linaro.org>
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [231128 08:41]:
> On 28/11/2023 09:32, Andreas Kemnade wrote:
> > On Tue, 28 Nov 2023 09:00:16 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >
> >>> +required:
> >>> + - compatible
> >>> + - clocks
> >>> + - '#clock-cells'
> >>
> >> reg is required. Device cannot take "reg" from parent, DTS does not work
> >> like this.
> >
> > Well, apparently they do... and I am just dealing with status quo and not
> > how it should be.
> > Look at commit 31fc1c63c2ae4a542e3c7ac572a10a59ece45c24
>
> Who designed clock-controller binding with a device node per each clock?
> This is ridiculous (although of course not your fault here)! Looking at
> omap3xxx-clocks.dtsi - all its children should be just defined by the
> driver, not by DTSI.
Earlier all the clocks were separate nodes, the ti,clksel binding made
things a bit better by grouping the seprate clock nodes so we don't have
multiple nodes with the same reg.. But yeah clksel instance clocks should
be clock@6 with reg = <6> if the clock bits are at bit 6. That would be
fairly easy to do if that helps, but in general I doubt anybody's going
to spend much effort to fix the omap3 legacy clocks atthis point.
For omap4 and later, things are a bit better as they use the clkctrl clocks:
Documentation/devicetree/bindings/clock/ti-clkctrl.txt
I don't think omap3 has any clkctrl clocks but if it does then that could
be used.
Regards,
Tony
next prev parent reply other threads:[~2023-11-28 10:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 20:23 [PATCH] dt-bindings: clock: ti: Convert interface.txt to json-schema Andreas Kemnade
2023-11-28 8:00 ` Krzysztof Kozlowski
2023-11-28 8:32 ` Andreas Kemnade
2023-11-28 8:41 ` Krzysztof Kozlowski
2023-11-28 10:43 ` Tony Lindgren [this message]
2023-11-28 20:41 ` Andreas Kemnade
2023-11-29 8:15 ` Krzysztof Kozlowski
2023-12-01 14:09 ` Andreas Kemnade
2023-12-01 14:17 ` Krzysztof Kozlowski
2023-12-01 14:41 ` Andreas Kemnade
2023-12-01 14:45 ` Krzysztof Kozlowski
2023-12-03 22:46 ` Andreas Kemnade
2023-12-04 7:59 ` Krzysztof Kozlowski
2023-11-28 17:16 ` Rob Herring
2023-11-29 10:12 ` Tony Lindgren
2024-02-08 10:22 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128104310.GS5169@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).