* [PATCH v4] dt-bindings: ufs: Add msi-parent for UFS MCQ
@ 2023-11-28 4:07 Ziqi Chen
2023-11-28 11:03 ` Manivannan Sadhasivam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ziqi Chen @ 2023-11-28 4:07 UTC (permalink / raw)
To: quic_asutoshd, quic_cang, bvanassche, mani, stanley.chu,
adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_ziqichen, quic_nguyenb, quic_nitirawa
Cc: linux-scsi, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, Sudeep Holla,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The Message Signaled Interrupts (MSI) support has been introduced in
UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
msi-parent property that point to the hardware entity which serves as
the MSI controller for this UFS controller.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
---
V3 -> V4: Corrected version change format.
V2 -> V3: Wrap commit message to meet Linux coding style.
V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to
incorporate the details about when MCQ/MSI got introduced.
---
Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
index 985ea8f..31fe7f3 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
+++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
@@ -87,6 +87,8 @@ properties:
description:
Specifies max. load that can be drawn from VCCQ2 supply.
+ msi-parent: true
+
dependencies:
freq-table-hz: [ clocks ]
operating-points-v2: [ clocks, clock-names ]
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-28 4:07 [PATCH v4] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
@ 2023-11-28 11:03 ` Manivannan Sadhasivam
2023-12-06 1:46 ` Martin K. Petersen
2023-12-14 4:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-11-28 11:03 UTC (permalink / raw)
To: Ziqi Chen
Cc: quic_asutoshd, quic_cang, bvanassche, stanley.chu, adrian.hunter,
beanhuo, avri.altman, junwoo80.lee, martin.petersen, quic_nguyenb,
quic_nitirawa, linux-scsi, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
Sudeep Holla,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Tue, Nov 28, 2023 at 12:07:47PM +0800, Ziqi Chen wrote:
> The Message Signaled Interrupts (MSI) support has been introduced in
> UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
> approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
> msi-parent property that point to the hardware entity which serves as
> the MSI controller for this UFS controller.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> V3 -> V4: Corrected version change format.
> V2 -> V3: Wrap commit message to meet Linux coding style.
> V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to
> incorporate the details about when MCQ/MSI got introduced.
> ---
> Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> index 985ea8f..31fe7f3 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> @@ -87,6 +87,8 @@ properties:
> description:
> Specifies max. load that can be drawn from VCCQ2 supply.
>
> + msi-parent: true
> +
> dependencies:
> freq-table-hz: [ clocks ]
> operating-points-v2: [ clocks, clock-names ]
> --
> 2.7.4
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-28 4:07 [PATCH v4] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-28 11:03 ` Manivannan Sadhasivam
@ 2023-12-06 1:46 ` Martin K. Petersen
2023-12-14 4:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-12-06 1:46 UTC (permalink / raw)
To: Ziqi Chen
Cc: quic_asutoshd, quic_cang, bvanassche, mani, stanley.chu,
adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_nguyenb, quic_nitirawa, linux-scsi,
Alim Akhtar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Geert Uytterhoeven, Sudeep Holla,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Ziqi,
> The Message Signaled Interrupts (MSI) support has been introduced in
> UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
> approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
> msi-parent property that point to the hardware entity which serves as
> the MSI controller for this UFS controller.
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-28 4:07 [PATCH v4] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-28 11:03 ` Manivannan Sadhasivam
2023-12-06 1:46 ` Martin K. Petersen
@ 2023-12-14 4:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-12-14 4:29 UTC (permalink / raw)
To: quic_asutoshd, quic_cang, bvanassche, mani, stanley.chu,
adrian.hunter, beanhuo, avri.altman, junwoo80.lee, quic_nguyenb,
quic_nitirawa, Ziqi Chen
Cc: Martin K . Petersen, linux-scsi, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
Sudeep Holla, devicetree, linux-kernel
On Tue, 28 Nov 2023 12:07:47 +0800, Ziqi Chen wrote:
> The Message Signaled Interrupts (MSI) support has been introduced in
> UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
> approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
> msi-parent property that point to the hardware entity which serves as
> the MSI controller for this UFS controller.
>
>
> [...]
Applied to 6.8/scsi-queue, thanks!
[1/1] dt-bindings: ufs: Add msi-parent for UFS MCQ
https://git.kernel.org/mkp/scsi/c/af85d689ae08
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-14 4:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 4:07 [PATCH v4] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-28 11:03 ` Manivannan Sadhasivam
2023-12-06 1:46 ` Martin K. Petersen
2023-12-14 4:29 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).