devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example
@ 2023-11-28 21:47 Rob Herring
  2023-11-29  8:30 ` Krzysztof Kozlowski
  2023-11-29 11:50 ` Philipp Zabel
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-11-28 21:47 UTC (permalink / raw)
  To: Philipp Zabel, Krzysztof Kozlowski, Conor Dooley, Wei Xu
  Cc: devicetree, linux-kernel

Binding examples should generally only cover what the binding covers. A
provider binding doesn't need to show consumers and vice-versa. The
hisilicon,hi3660-reset binding example has both, so let's drop them.

This also fixes an undocumented (by schema) compatible warning for
"hisilicon,hi3660-iomcu".

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../reset/hisilicon,hi3660-reset.yaml         | 25 +------------------
 1 file changed, 1 insertion(+), 24 deletions(-)

diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml
index cdfcf32c53fa..e4de002d6903 100644
--- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml
@@ -50,32 +50,9 @@ additionalProperties: false
 
 examples:
   - |
-    #include <dt-bindings/interrupt-controller/irq.h>
-    #include <dt-bindings/interrupt-controller/arm-gic.h>
-    #include <dt-bindings/clock/hi3660-clock.h>
-
-    iomcu: iomcu@ffd7e000 {
-        compatible = "hisilicon,hi3660-iomcu", "syscon";
-        reg = <0xffd7e000 0x1000>;
-    };
-
-    iomcu_rst: iomcu_rst_controller {
+    iomcu_rst_controller {
         compatible = "hisilicon,hi3660-reset";
         hisilicon,rst-syscon = <&iomcu>;
         #reset-cells = <2>;
     };
-
-    /* Specifying reset lines connected to IP modules */
-    i2c@ffd71000 {
-        compatible = "snps,designware-i2c";
-        reg = <0xffd71000 0x1000>;
-        interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
-        #address-cells = <1>;
-        #size-cells = <0>;
-        clock-frequency = <400000>;
-        clocks = <&crg_ctrl HI3660_CLK_GATE_I2C0>;
-        resets = <&iomcu_rst 0x20 3>;
-        pinctrl-names = "default";
-        pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
-    };
 ...
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example
  2023-11-28 21:47 [PATCH] dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example Rob Herring
@ 2023-11-29  8:30 ` Krzysztof Kozlowski
  2023-11-29 11:50 ` Philipp Zabel
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-29  8:30 UTC (permalink / raw)
  To: Rob Herring, Philipp Zabel, Krzysztof Kozlowski, Conor Dooley,
	Wei Xu
  Cc: devicetree, linux-kernel

On 28/11/2023 22:47, Rob Herring wrote:
> Binding examples should generally only cover what the binding covers. A
> provider binding doesn't need to show consumers and vice-versa. The
> hisilicon,hi3660-reset binding example has both, so let's drop them.
> 
> This also fixes an undocumented (by schema) compatible warning for
> "hisilicon,hi3660-iomcu".
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example
  2023-11-28 21:47 [PATCH] dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example Rob Herring
  2023-11-29  8:30 ` Krzysztof Kozlowski
@ 2023-11-29 11:50 ` Philipp Zabel
  1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2023-11-29 11:50 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Conor Dooley, Wei Xu, Rob Herring
  Cc: devicetree, linux-kernel

On Tue, 28 Nov 2023 15:47:58 -0600, Rob Herring wrote:
> Binding examples should generally only cover what the binding covers. A
> provider binding doesn't need to show consumers and vice-versa. The
> hisilicon,hi3660-reset binding example has both, so let's drop them.
> 
> This also fixes an undocumented (by schema) compatible warning for
> "hisilicon,hi3660-iomcu".
> 
> [...]

Applied to reset/next, thanks!

[1/1] dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=c3c46acd5be9

regards
Philipp


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-29 11:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 21:47 [PATCH] dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example Rob Herring
2023-11-29  8:30 ` Krzysztof Kozlowski
2023-11-29 11:50 ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).