From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F303D4879D; Thu, 30 Nov 2023 14:58:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jpNt6hKj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C164C433C7; Thu, 30 Nov 2023 14:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701356326; bh=8Js8Hy2kLo1L6YkFwnzWN4hkYezVwJRoYHViVMUicgs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jpNt6hKjXd68EwOlbz1pBTdNJaj7J+27Hno3vGBqWlu+gZizrLjcv7HizbZ2UACJ7 ASITdqOtS3LB7mfmk4ik5b0U4OJkQNaTEw5/X/w11xwGLogCN+SdkqBOvGMQ1xwm9D CvJV3niMs7u1kSvjFKbpJZiuQEpCM+I+h7FVBDT8nsoe+7CNZCo481jqPbUGuohsFg BpEhp8JVi9wbZjpUjwq+9GhD0bHyo815nC4O7BBTKhW5tfZaO6F01LXNVnhp7bddkP fqOM5l0H9HSKegNN9HxdDUOPlEnk2vkUzsyf7YxjbI7rES86ZxFx+Ng9oqJJnYpeMG EEAJ1+mSaNQ+A== Date: Thu, 30 Nov 2023 14:58:41 +0000 From: Conor Dooley To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com, Conor Dooley , Guenter Roeck , Jean Delvare , Jonathan Cameron , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: Re: [PATCH] dt-bindings: hwmon: Increase max number of io-channels Message-ID: <20231130-power-rubbed-fbf64a8c6978@spud> References: <441d9babc7042892350a58ba4300df4761876ae3.1701334008.git.michal.simek@amd.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BPoyXFuPPPfwP3S7" Content-Disposition: inline In-Reply-To: <441d9babc7042892350a58ba4300df4761876ae3.1701334008.git.michal.simek@amd.com> --BPoyXFuPPPfwP3S7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 30, 2023 at 09:46:54AM +0100, Michal Simek wrote: > arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts is defining 30 channels > that's why increase it. > But AMS binding defines 51 channels > Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml > that's why increase number to 51. Please write commit messages for bindings in terms of how they relate to some hardware. In this case I think it would be sufficient to say that the Analog Monitoring system has 51 channels, the opening sentence about the dts as justification provides no actionable information. Acked-by: Conor Dooley Cheers, Conor. > Signed-off-by: Michal Simek > --- >=20 > Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml b/Doc= umentation/devicetree/bindings/hwmon/iio-hwmon.yaml > index e5b24782f448..be5c7d4579bb 100644 > --- a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml > +++ b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml > @@ -19,7 +19,7 @@ properties: > =20 > io-channels: > minItems: 1 > - maxItems: 8 # Should be enough > + maxItems: 51 # Should be enough > description: > > List of phandles to ADC channels to read the monitoring values > =20 > --=20 > 2.36.1 >=20 --BPoyXFuPPPfwP3S7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWijIQAKCRB4tDGHoIJi 0lICAQC1KW3GVEI4tqQWELA4CLCh/wITQ8ofp4IPCooF4IJVWQD+NKt3+qwCkPnx L96KirOZwabT/HBwdu4dRpfvte7q4Ak= =DlYh -----END PGP SIGNATURE----- --BPoyXFuPPPfwP3S7--