From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1CF524A3 for ; Thu, 30 Nov 2023 15:42:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="teECoiBP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 521EFC433C7; Thu, 30 Nov 2023 15:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701358973; bh=WlLJfUiHU4McYxn94NiMcp46fAMc3TUOTPbaqBQLG/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=teECoiBPqM0U8Ehit9ioXGecjoILrpbNTcS1O2v2z0ZmW1ykgsH7a4/6pqOApmFM0 iXoroSoJBwStm48mdd1gqCoLdp7Nk6hOIek2RQgE8wHHgST2c3TGg/smVi6rudWJQs HPnhortTfNkXdF6MXLsRFfj8q3q3tHh4x8lYuZ9h5PScStSDii4kaTjdv3yGvUV1DT E5vlrni/BHqpfhlweGh5vsL1ewX6wVf9S2P84sMFIcXrut/zAznT9cm/87IHbF956N xz+JcqjR/7nqj2w2aUkMzRNz+RkcsojXMc3clL9jGOsWNLZN/hXk3M8HZJ299zaqP5 2k+p13+Ph0Klw== Date: Thu, 30 Nov 2023 15:42:48 +0000 From: Conor Dooley To: Thomas Richard Cc: Nishanth Menon , Tero Kristo , Santosh Shilimkar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vignesh Raghavendra , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH 1/5] dt-bindings: arm: keystone: add ti,j7200-sci compatible Message-ID: <20231130-repugnant-aghast-0bc35af8de3c@spud> References: <20231129-j7200-tisci-s2r-v1-0-c1d5964ed574@bootlin.com> <20231129-j7200-tisci-s2r-v1-1-c1d5964ed574@bootlin.com> <20231129-caress-banister-5b5ccbf183e6@spud> <20231129-crawling-gaming-76077ed03c57@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zEaYWprFLeGvpHlX" Content-Disposition: inline In-Reply-To: <20231129-crawling-gaming-76077ed03c57@spud> --zEaYWprFLeGvpHlX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 29, 2023 at 03:38:04PM +0000, Conor Dooley wrote: > On Wed, Nov 29, 2023 at 03:34:20PM +0000, Conor Dooley wrote: > > On Wed, Nov 29, 2023 at 04:31:17PM +0100, Thomas Richard wrote: > > > On j7200, during suspend to ram the soc is powered-off. > > > At resume requested irqs shall be restored which is a different behav= ior > > > from other platforms. > > >=20 > > > Signed-off-by: Thomas Richard > >=20 > > Acked-by: Conor Dooley >=20 > Un-Acked. Your dts patch contradicts this one. >=20 > Is the programming model compatible with the existing devices? To be > compatible, the existing device only need to support a compatible subset > of behaviours. > If so, this patch is wrong. If not, then the dts one is. Given Andrew's response, it looks like the dts patch is the correct one of the two, and this patch should document the k2g as a fallback for the jh7200. Cheers, Conor. --zEaYWprFLeGvpHlX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWitdwAKCRB4tDGHoIJi 0mkhAP98vayPMHoouzmPwyTjP5SrWcx1W4mXtH9nl8OtgqZpbQEAzHUQkAjTUikM Ync+Qp1rElNGrwDq0R1MRMGtTgimSwc= =2kcW -----END PGP SIGNATURE----- --zEaYWprFLeGvpHlX--