devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] arm64: dts: mediatek: Random DT cleanups
@ 2023-11-30  7:40 Chen-Yu Tsai
  2023-11-30  7:40 ` [PATCH 1/3] arm64: dts: mt8183: kukui-jacuzzi: Drop bogus anx7625 panel_flag property Chen-Yu Tsai
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Chen-Yu Tsai @ 2023-11-30  7:40 UTC (permalink / raw)
  To: Matthias Brugger, AngeloGioacchino Del Regno
  Cc: Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

Hi,

Here are some random DT cleanups that I've accumulated. This should get
rid of some warnings.

Please have a look.


ChenYu

Chen-Yu Tsai (3):
  arm64: dts: mt8183: kukui-jacuzzi: Drop bogus anx7625 panel_flag
    property
  arm64: dts: mt6358: Drop bogus "regulator-fixed" compatible properties
  arm64: dts: mediatek: mt8186: Fix alias prefix for ovl_2l0

 arch/arm64/boot/dts/mediatek/mt6358.dtsi            | 13 -------------
 .../boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi     |  1 -
 arch/arm64/boot/dts/mediatek/mt8186.dtsi            |  2 +-
 3 files changed, 1 insertion(+), 15 deletions(-)

-- 
2.43.0.rc2.451.g8631bc7472-goog


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] arm64: dts: mt8183: kukui-jacuzzi: Drop bogus anx7625 panel_flag property
  2023-11-30  7:40 [PATCH 0/3] arm64: dts: mediatek: Random DT cleanups Chen-Yu Tsai
@ 2023-11-30  7:40 ` Chen-Yu Tsai
  2023-12-01  9:04   ` AngeloGioacchino Del Regno
  2023-11-30  7:40 ` [PATCH 2/3] arm64: dts: mt6358: Drop bogus "regulator-fixed" compatible properties Chen-Yu Tsai
  2023-11-30  7:40 ` [PATCH 3/3] arm64: dts: mediatek: mt8186: Fix alias prefix for ovl_2l0 Chen-Yu Tsai
  2 siblings, 1 reply; 7+ messages in thread
From: Chen-Yu Tsai @ 2023-11-30  7:40 UTC (permalink / raw)
  To: Matthias Brugger, AngeloGioacchino Del Regno
  Cc: Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

The panel_flag property was used in ChromeOS's downstream kernel. It was
used to signal whether the downstream device was a fixed panel or
a connector for an external display.

This property was dropped in favor of standard OF graph descrptions of
downstream display panels and bridges.

Drop the property from the device tree file.

Fixes: cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index bf97b60ae4d1..09e658bc30e6 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
@@ -147,7 +147,6 @@ anx_bridge: anx7625@58 {
 		reg = <0x58>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&anx7625_pins>;
-		panel_flags = <1>;
 		enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
 		reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
 		vdd10-supply = <&pp1200_mipibrdg>;
-- 
2.43.0.rc2.451.g8631bc7472-goog


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] arm64: dts: mt6358: Drop bogus "regulator-fixed" compatible properties
  2023-11-30  7:40 [PATCH 0/3] arm64: dts: mediatek: Random DT cleanups Chen-Yu Tsai
  2023-11-30  7:40 ` [PATCH 1/3] arm64: dts: mt8183: kukui-jacuzzi: Drop bogus anx7625 panel_flag property Chen-Yu Tsai
@ 2023-11-30  7:40 ` Chen-Yu Tsai
  2023-12-01  9:03   ` AngeloGioacchino Del Regno
  2023-11-30  7:40 ` [PATCH 3/3] arm64: dts: mediatek: mt8186: Fix alias prefix for ovl_2l0 Chen-Yu Tsai
  2 siblings, 1 reply; 7+ messages in thread
From: Chen-Yu Tsai @ 2023-11-30  7:40 UTC (permalink / raw)
  To: Matthias Brugger, AngeloGioacchino Del Regno
  Cc: Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

Whether a regulator under the MT6358 PMIC is a fixed regulator or not is
derived from the node name. Compatible string properties are not used.
This causes validation errors after the regulator binding is converted
to DT schema.

Drop the bogus "regulator-fixed" compatible properties from the PMIC's
regulator sub-nodes.

Fixes: 9f8872221674 ("arm64: dts: mt6358: add PMIC MT6358 related nodes")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 arch/arm64/boot/dts/mediatek/mt6358.dtsi | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
index 186898f9384b..ad5e4022e06d 100644
--- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
@@ -128,7 +128,6 @@ mt6358_vibr_reg: ldo_vibr {
 			};
 
 			mt6358_vrf12_reg: ldo_vrf12 {
-				compatible = "regulator-fixed";
 				regulator-name = "vrf12";
 				regulator-min-microvolt = <1200000>;
 				regulator-max-microvolt = <1200000>;
@@ -136,7 +135,6 @@ mt6358_vrf12_reg: ldo_vrf12 {
 			};
 
 			mt6358_vio18_reg: ldo_vio18 {
-				compatible = "regulator-fixed";
 				regulator-name = "vio18";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
@@ -153,7 +151,6 @@ mt6358_vusb_reg: ldo_vusb {
 			};
 
 			mt6358_vcamio_reg: ldo_vcamio {
-				compatible = "regulator-fixed";
 				regulator-name = "vcamio";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
@@ -168,7 +165,6 @@ mt6358_vcamd_reg: ldo_vcamd {
 			};
 
 			mt6358_vcn18_reg: ldo_vcn18 {
-				compatible = "regulator-fixed";
 				regulator-name = "vcn18";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
@@ -176,7 +172,6 @@ mt6358_vcn18_reg: ldo_vcn18 {
 			};
 
 			mt6358_vfe28_reg: ldo_vfe28 {
-				compatible = "regulator-fixed";
 				regulator-name = "vfe28";
 				regulator-min-microvolt = <2800000>;
 				regulator-max-microvolt = <2800000>;
@@ -193,7 +188,6 @@ mt6358_vsram_proc11_reg: ldo_vsram_proc11 {
 			};
 
 			mt6358_vcn28_reg: ldo_vcn28 {
-				compatible = "regulator-fixed";
 				regulator-name = "vcn28";
 				regulator-min-microvolt = <2800000>;
 				regulator-max-microvolt = <2800000>;
@@ -218,7 +212,6 @@ mt6358_vsram_gpu_reg: ldo_vsram_gpu {
 			};
 
 			mt6358_vxo22_reg: ldo_vxo22 {
-				compatible = "regulator-fixed";
 				regulator-name = "vxo22";
 				regulator-min-microvolt = <2200000>;
 				regulator-max-microvolt = <2200000>;
@@ -234,7 +227,6 @@ mt6358_vefuse_reg: ldo_vefuse {
 			};
 
 			mt6358_vaux18_reg: ldo_vaux18 {
-				compatible = "regulator-fixed";
 				regulator-name = "vaux18";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
@@ -249,7 +241,6 @@ mt6358_vmch_reg: ldo_vmch {
 			};
 
 			mt6358_vbif28_reg: ldo_vbif28 {
-				compatible = "regulator-fixed";
 				regulator-name = "vbif28";
 				regulator-min-microvolt = <2800000>;
 				regulator-max-microvolt = <2800000>;
@@ -280,7 +271,6 @@ mt6358_vemc_reg: ldo_vemc {
 			};
 
 			mt6358_vio28_reg: ldo_vio28 {
-				compatible = "regulator-fixed";
 				regulator-name = "vio28";
 				regulator-min-microvolt = <2800000>;
 				regulator-max-microvolt = <2800000>;
@@ -288,7 +278,6 @@ mt6358_vio28_reg: ldo_vio28 {
 			};
 
 			mt6358_va12_reg: ldo_va12 {
-				compatible = "regulator-fixed";
 				regulator-name = "va12";
 				regulator-min-microvolt = <1200000>;
 				regulator-max-microvolt = <1200000>;
@@ -297,7 +286,6 @@ mt6358_va12_reg: ldo_va12 {
 			};
 
 			mt6358_vrf18_reg: ldo_vrf18 {
-				compatible = "regulator-fixed";
 				regulator-name = "vrf18";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
@@ -333,7 +321,6 @@ mt6358_vldo28_reg: ldo_vldo28 {
 			};
 
 			mt6358_vaud28_reg: ldo_vaud28 {
-				compatible = "regulator-fixed";
 				regulator-name = "vaud28";
 				regulator-min-microvolt = <2800000>;
 				regulator-max-microvolt = <2800000>;
-- 
2.43.0.rc2.451.g8631bc7472-goog


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] arm64: dts: mediatek: mt8186: Fix alias prefix for ovl_2l0
  2023-11-30  7:40 [PATCH 0/3] arm64: dts: mediatek: Random DT cleanups Chen-Yu Tsai
  2023-11-30  7:40 ` [PATCH 1/3] arm64: dts: mt8183: kukui-jacuzzi: Drop bogus anx7625 panel_flag property Chen-Yu Tsai
  2023-11-30  7:40 ` [PATCH 2/3] arm64: dts: mt6358: Drop bogus "regulator-fixed" compatible properties Chen-Yu Tsai
@ 2023-11-30  7:40 ` Chen-Yu Tsai
  2023-12-01  9:04   ` AngeloGioacchino Del Regno
  2 siblings, 1 reply; 7+ messages in thread
From: Chen-Yu Tsai @ 2023-11-30  7:40 UTC (permalink / raw)
  To: Matthias Brugger, AngeloGioacchino Del Regno
  Cc: Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

The alias prefix for ovl_2l (2 layer overlay) is "ovl-2l", not "ovl_2l".

Fix this.

Fixes: 7e07d3322de2 ("arm64: dts: mediatek: mt8186: Add display nodes")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 arch/arm64/boot/dts/mediatek/mt8186.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
index df0c04f2ba1d..021397671099 100644
--- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
@@ -22,7 +22,7 @@ / {
 
 	aliases {
 		ovl0 = &ovl0;
-		ovl_2l0 = &ovl_2l0;
+		ovl-2l0 = &ovl_2l0;
 		rdma0 = &rdma0;
 		rdma1 = &rdma1;
 	};
-- 
2.43.0.rc2.451.g8631bc7472-goog


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/3] arm64: dts: mt6358: Drop bogus "regulator-fixed" compatible properties
  2023-11-30  7:40 ` [PATCH 2/3] arm64: dts: mt6358: Drop bogus "regulator-fixed" compatible properties Chen-Yu Tsai
@ 2023-12-01  9:03   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-12-01  9:03 UTC (permalink / raw)
  To: Chen-Yu Tsai, Matthias Brugger
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek

Il 30/11/23 08:40, Chen-Yu Tsai ha scritto:
> Whether a regulator under the MT6358 PMIC is a fixed regulator or not is
> derived from the node name. Compatible string properties are not used.
> This causes validation errors after the regulator binding is converted
> to DT schema.
> 
> Drop the bogus "regulator-fixed" compatible properties from the PMIC's
> regulator sub-nodes.
> 
> Fixes: 9f8872221674 ("arm64: dts: mt6358: add PMIC MT6358 related nodes")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] arm64: dts: mediatek: mt8186: Fix alias prefix for ovl_2l0
  2023-11-30  7:40 ` [PATCH 3/3] arm64: dts: mediatek: mt8186: Fix alias prefix for ovl_2l0 Chen-Yu Tsai
@ 2023-12-01  9:04   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-12-01  9:04 UTC (permalink / raw)
  To: Chen-Yu Tsai, Matthias Brugger
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek

Il 30/11/23 08:40, Chen-Yu Tsai ha scritto:
> The alias prefix for ovl_2l (2 layer overlay) is "ovl-2l", not "ovl_2l".
> 
> Fix this.
> 
> Fixes: 7e07d3322de2 ("arm64: dts: mediatek: mt8186: Add display nodes")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] arm64: dts: mt8183: kukui-jacuzzi: Drop bogus anx7625 panel_flag property
  2023-11-30  7:40 ` [PATCH 1/3] arm64: dts: mt8183: kukui-jacuzzi: Drop bogus anx7625 panel_flag property Chen-Yu Tsai
@ 2023-12-01  9:04   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-12-01  9:04 UTC (permalink / raw)
  To: Chen-Yu Tsai, Matthias Brugger
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek

Il 30/11/23 08:40, Chen-Yu Tsai ha scritto:
> The panel_flag property was used in ChromeOS's downstream kernel. It was
> used to signal whether the downstream device was a fixed panel or
> a connector for an external display.
> 
> This property was dropped in favor of standard OF graph descrptions of
> downstream display panels and bridges.
> 
> Drop the property from the device tree file.
> 
> Fixes: cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-12-01  9:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-30  7:40 [PATCH 0/3] arm64: dts: mediatek: Random DT cleanups Chen-Yu Tsai
2023-11-30  7:40 ` [PATCH 1/3] arm64: dts: mt8183: kukui-jacuzzi: Drop bogus anx7625 panel_flag property Chen-Yu Tsai
2023-12-01  9:04   ` AngeloGioacchino Del Regno
2023-11-30  7:40 ` [PATCH 2/3] arm64: dts: mt6358: Drop bogus "regulator-fixed" compatible properties Chen-Yu Tsai
2023-12-01  9:03   ` AngeloGioacchino Del Regno
2023-11-30  7:40 ` [PATCH 3/3] arm64: dts: mediatek: mt8186: Fix alias prefix for ovl_2l0 Chen-Yu Tsai
2023-12-01  9:04   ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).