* [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name
@ 2023-11-30 17:19 Johan Hovold
2023-12-01 8:42 ` Krzysztof Kozlowski
2023-12-07 15:25 ` (subset) " Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Johan Hovold @ 2023-11-30 17:19 UTC (permalink / raw)
To: Pavel Machek, Lee Jones
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, inux-arm-msm, linux-leds,
devicetree, linux-kernel, Johan Hovold
The led controller is a child of an SPMI PMIC, which in turn sits on an
SPMI bus.
While at it, add some newline separators to improve readability.
Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
index a8736fd5a539..1ba607685f5f 100644
--- a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
+++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
@@ -89,9 +89,11 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/leds/common.h>
- spmi {
+
+ pmic {
#address-cells = <1>;
#size-cells = <0>;
+
led-controller@ee00 {
compatible = "qcom,pm8350c-flash-led", "qcom,spmi-flash-led";
reg = <0xee00>;
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name
2023-11-30 17:19 [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name Johan Hovold
@ 2023-12-01 8:42 ` Krzysztof Kozlowski
2023-12-01 9:38 ` Johan Hovold
2023-12-07 15:25 ` (subset) " Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-01 8:42 UTC (permalink / raw)
To: Johan Hovold, Pavel Machek, Lee Jones
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, inux-arm-msm, linux-leds,
devicetree, linux-kernel
On 30/11/2023 18:19, Johan Hovold wrote:
> The led controller is a child of an SPMI PMIC, which in turn sits on an
> SPMI bus.
>
> While at it, add some newline separators to improve readability.
>
> Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller")
Nothing to fix here, just an example code.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name
2023-12-01 8:42 ` Krzysztof Kozlowski
@ 2023-12-01 9:38 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2023-12-01 9:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Johan Hovold, Pavel Machek, Lee Jones, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, inux-arm-msm, linux-leds, devicetree, linux-kernel
On Fri, Dec 01, 2023 at 09:42:02AM +0100, Krzysztof Kozlowski wrote:
> On 30/11/2023 18:19, Johan Hovold wrote:
> > The led controller is a child of an SPMI PMIC, which in turn sits on an
> > SPMI bus.
> >
> > While at it, add some newline separators to improve readability.
> >
> > Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller")
>
> Nothing to fix here, just an example code.
I'll just refer to my reply here for completeness:
https://lore.kernel.org/all/ZWmn6uicNIqqSwoE@hovoldconsulting.com/
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: (subset) [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name
2023-11-30 17:19 [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name Johan Hovold
2023-12-01 8:42 ` Krzysztof Kozlowski
@ 2023-12-07 15:25 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2023-12-07 15:25 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Johan Hovold
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, inux-arm-msm, linux-leds,
devicetree, linux-kernel
On Thu, 30 Nov 2023 18:19:40 +0100, Johan Hovold wrote:
> The led controller is a child of an SPMI PMIC, which in turn sits on an
> SPMI bus.
>
> While at it, add some newline separators to improve readability.
>
>
Applied, thanks!
[1/1] dt-bindings: leds: qcom,spmi-flash-led: fix example node name
commit: e9a3374e5c545e5eade4623098b958d2f4073455
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-07 15:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-30 17:19 [PATCH] dt-bindings: leds: qcom,spmi-flash-led: fix example node name Johan Hovold
2023-12-01 8:42 ` Krzysztof Kozlowski
2023-12-01 9:38 ` Johan Hovold
2023-12-07 15:25 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).