* [PATCH] dt-bindings: watchdog: qcom,pm8916-wdt: add parent spmi node to example
@ 2023-11-30 17:42 Johan Hovold
2023-12-01 8:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2023-11-30 17:42 UTC (permalink / raw)
To: Guenter Roeck, Wim Van Sebroeck
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel, Johan Hovold
The PM8916 watchdog is part of an SPMI PMIC, which lives on an SPMI bus.
Add a parent SPMI bus node with an '#address-cells' of 2 and
'#size-cells' of 0 instead of relying on the fact that the default
number of register cells happen to match (i.e. 1 + 1).
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../bindings/watchdog/qcom,pm8916-wdt.yaml | 33 +++++++++++--------
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml
index 568eb8480fc3..dc6af204e8af 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml
@@ -30,22 +30,27 @@ examples:
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/spmi/spmi.h>
- pmic@0 {
- compatible = "qcom,pm8916", "qcom,spmi-pmic";
- reg = <0x0 SPMI_USID>;
- #address-cells = <1>;
+ spmi {
+ #address-cells = <2>;
#size-cells = <0>;
- pon@800 {
- compatible = "qcom,pm8916-pon";
- reg = <0x800>;
- mode-bootloader = <0x2>;
- mode-recovery = <0x1>;
-
- watchdog {
- compatible = "qcom,pm8916-wdt";
- interrupts = <0x0 0x8 6 IRQ_TYPE_EDGE_RISING>;
- timeout-sec = <60>;
+ pmic@0 {
+ compatible = "qcom,pm8916", "qcom,spmi-pmic";
+ reg = <0x0 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pon@800 {
+ compatible = "qcom,pm8916-pon";
+ reg = <0x800>;
+ mode-bootloader = <0x2>;
+ mode-recovery = <0x1>;
+
+ watchdog {
+ compatible = "qcom,pm8916-wdt";
+ interrupts = <0x0 0x8 6 IRQ_TYPE_EDGE_RISING>;
+ timeout-sec = <60>;
+ };
};
};
};
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dt-bindings: watchdog: qcom,pm8916-wdt: add parent spmi node to example
2023-11-30 17:42 [PATCH] dt-bindings: watchdog: qcom,pm8916-wdt: add parent spmi node to example Johan Hovold
@ 2023-12-01 8:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-01 8:27 UTC (permalink / raw)
To: Johan Hovold, Guenter Roeck, Wim Van Sebroeck
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
On 30/11/2023 18:42, Johan Hovold wrote:
> The PM8916 watchdog is part of an SPMI PMIC, which lives on an SPMI bus.
>
> Add a parent SPMI bus node with an '#address-cells' of 2 and
> '#size-cells' of 0 instead of relying on the fact that the default
> number of register cells happen to match (i.e. 1 + 1).
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-01 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-30 17:42 [PATCH] dt-bindings: watchdog: qcom,pm8916-wdt: add parent spmi node to example Johan Hovold
2023-12-01 8:27 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox