From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E11E0883A; Fri, 1 Dec 2023 05:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MMHU/+pB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3204CC433C8; Fri, 1 Dec 2023 05:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701410059; bh=XWTd2RLDgng2C3LTUEtomheeaQdarXMuLAND323s2cc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MMHU/+pBkRXhRy4fG2fEF7IobU50XbzhbUaAEaIhAE2DFp3BLYAJOvfs4p1nzh1zH zBrwC2W3kdxWr1uRMew1MmondiRuqIgMCYs2G/44N9cdQX0RfjJ6p+oNnKI99Xbtn0 z1wpmGVKOJ/idn2biFhL4OnsYL9spQzmkoD1y3+faZ+68I2GrDueqzSB5o1tEfQAfJ uLB/2iKjRzx22/4vvxLCfk6rHkaWTAEDqvGIYSRklhD0AsyEJXppi7niEdgCGErAVw KbrY2R7q6nn9UIo9Bc+BhApDVBCCyvryR1bCFCujqu613A9dXJBXJUcGDOA9XeaeCO 1mXbG7aeqjFJg== Date: Fri, 1 Dec 2023 11:23:59 +0530 From: Manivannan Sadhasivam To: Mrinmay Sarkar Cc: agross@kernel.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, dmitry.baryshkov@linaro.org, robh@kernel.org, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com, quic_parass@quicinc.com, quic_schintav@quicinc.com, quic_shijjose@quicinc.com, Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mhi@lists.linux.dev Subject: Re: [PATCH v8 4/5] PCI: epf-mhi: Add support for SA8775P Message-ID: <20231201055359.GI4009@thinkpad> References: <1699669982-7691-1-git-send-email-quic_msarkar@quicinc.com> <1699669982-7691-5-git-send-email-quic_msarkar@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1699669982-7691-5-git-send-email-quic_msarkar@quicinc.com> On Sat, Nov 11, 2023 at 08:03:00AM +0530, Mrinmay Sarkar wrote: > Add support for Qualcomm Snapdragon SA8775P SoC to the EPF driver. > SA8775P is currently reusing the PID 0x0306 (the default one hardcoded > in the config space header) as the unique PID is not yet allocated. > But the host side stack works fine with the default PID. It will get > updated once the PID is finalized. Currently, it has no fixed PCI class, > so it is being advertised as "PCI_CLASS_OTHERS". > > Signed-off-by: Mrinmay Sarkar Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/endpoint/functions/pci-epf-mhi.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c > index 5b0515a..68801c2 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-mhi.c > +++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c > @@ -114,6 +114,22 @@ static const struct pci_epf_mhi_ep_info sm8450_info = { > .flags = MHI_EPF_USE_DMA, > }; > > +static struct pci_epf_header sa8775p_header = { > + .vendorid = PCI_VENDOR_ID_QCOM, > + .deviceid = 0x0306, /* FIXME: Update deviceid for sa8775p EP */ > + .baseclass_code = PCI_CLASS_OTHERS, > + .interrupt_pin = PCI_INTERRUPT_INTA, > +}; > + > +static const struct pci_epf_mhi_ep_info sa8775p_info = { > + .config = &mhi_v1_config, > + .epf_header = &sa8775p_header, > + .bar_num = BAR_0, > + .epf_flags = PCI_BASE_ADDRESS_MEM_TYPE_32, > + .msi_count = 32, > + .mru = 0x8000, > +}; > + > struct pci_epf_mhi { > const struct pci_epc_features *epc_features; > const struct pci_epf_mhi_ep_info *info; > @@ -677,6 +693,7 @@ static int pci_epf_mhi_probe(struct pci_epf *epf, > } > > static const struct pci_epf_device_id pci_epf_mhi_ids[] = { > + { .name = "pci_epf_mhi_sa8775p", .driver_data = (kernel_ulong_t)&sa8775p_info }, > { .name = "pci_epf_mhi_sdx55", .driver_data = (kernel_ulong_t)&sdx55_info }, > { .name = "pci_epf_mhi_sm8450", .driver_data = (kernel_ulong_t)&sm8450_info }, > {}, > -- > 2.7.4 > -- மணிவண்ணன் சதாசிவம்