From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MprJc8WC" Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C229493 for ; Thu, 30 Nov 2023 22:07:31 -0800 (PST) Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-67a44ee7ab3so10677536d6.0 for ; Thu, 30 Nov 2023 22:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701410851; x=1702015651; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Kgy5hlcvWH3mv4+OMDEYg4gGuadNVhIN6Sw8oNb6ClE=; b=MprJc8WCS3au6vGnDxfd3X5nt9Lzyovn8sGqZPtTb3RH5vp5Jaa9UiRmNZd/QRwKFs xzT5G+6+UDFF1NRNx1iWfDDrMSpMPtTrTEGIfqkTzdQrGVQZbu41QHLM9AMRxliDmhX1 mpR2ODU+RbBUE3rUIS0v88FZbPLneqp9DiK6udeZE9QuGGx5YcHRYW6b66aLq3z8sV1Z hxfaf13MtVd7+cvPI4QI1+646esMflrm3oVnvOoPE1pVrpUftnVCeGRVj7XeJiN5C8Vr N2OKBcG6vgY9gh53uco53JQ29aQ40k8ue+GEWPMMj9PWha4DpRXQgYDydPkzOgRCjuCW KeqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701410851; x=1702015651; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kgy5hlcvWH3mv4+OMDEYg4gGuadNVhIN6Sw8oNb6ClE=; b=cG+s5A3KBKUt68ix/HWFboddMNke6VwMBWIvyuk4/vFQ1w8A2pDexoWLTGEFzt2Ajx Fzv4N3U6XlatYQlerTFi2oeuainnUAmGq/7uc5zUarY+JnC1XBxRdNvHgYuDoT2r1Np2 9zF5pguW2YkFUVMrNR6mwW1LSFJnSENfGsuU+KXvisbisK18u2kJGj4V78btv8EYkRQt SdqnIaqqF3A6Q/iyUXZzDFnfv4cnVniwI31QDjqwYyVx6x6Ec8EIA5Wh4tareeuJK0Yr CDQdmAwKmYNXZdRTHpJxEXzq3k3v2JKF9NhDUnBAgT1Jx/R3XWGql/SacQ8zs/Vt5Iw0 Pntg== X-Gm-Message-State: AOJu0Yxz1gwTtuzGHnX4ueKZkAv8u3D+RKBUiPR4pfK5l5C5rcxBB58r afLYOT7Wq9MubQ9Le35LAHcj X-Google-Smtp-Source: AGHT+IHu2ksyKFCtF20WA7pQITHq93w/lCv7QCJfM5F0X7XunthNNyJrRVZbimdwRtLy0LpBiPTuQw== X-Received: by 2002:a05:620a:34d:b0:77d:cd41:1254 with SMTP id t13-20020a05620a034d00b0077dcd411254mr7559516qkm.12.1701410850808; Thu, 30 Nov 2023 22:07:30 -0800 (PST) Received: from thinkpad ([117.213.102.92]) by smtp.gmail.com with ESMTPSA id d23-20020a05620a159700b0077d749de2a3sm1199149qkk.67.2023.11.30.22.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 22:07:30 -0800 (PST) Date: Fri, 1 Dec 2023 11:37:16 +0530 From: Manivannan Sadhasivam To: Krishna Chaitanya Chundru Cc: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_ramkri@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_vpernami@quicinc.com, quic_parass@quicinc.com Subject: Re: [PATCH v3 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property Message-ID: <20231201060716.GJ4009@thinkpad> References: <20231127-refclk_always_on-v3-0-26d969fa8f1d@quicinc.com> <20231127-refclk_always_on-v3-1-26d969fa8f1d@quicinc.com> <78815f1b-7390-40de-8afd-ac71806f4051@linaro.org> <24fae40a-453b-b14c-923f-88758a246aa7@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <24fae40a-453b-b14c-923f-88758a246aa7@quicinc.com> On Tue, Nov 28, 2023 at 02:49:18PM +0530, Krishna Chaitanya Chundru wrote: > > On 11/28/2023 2:26 PM, Krzysztof Kozlowski wrote: > > On 27/11/2023 13:13, Krishna chaitanya chundru wrote: > > > Document qcom,refclk-always-on property which is needed in some platforms > > > to supply refclk even in PCIe low power states. > > > > > > Signed-off-by: Krishna chaitanya chundru > > > --- > > > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > > > index 2c3d6553a7ba..c747c9f35795 100644 > > > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > > > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > > > @@ -93,6 +93,13 @@ properties: > > > "#phy-cells": > > > const: 0 > > > + qcom,refclk-always-on: > > > + type: boolean > > > + description: In some platform where PCIe switch is connected, pcie switch due to some design > > You received a comment to use proper wrapping: 80. Please implement it. > I will update this. > > > + limitation fails to propage clkreq signal to the host and due to that host will not send > > > + refclk, which results in linkdown in L1.2 or L1.1 exit initiated by EP. > > > + This property if set keeps refclk always on even in Low power states. > > The property name suggests that's the state of hardware - refclk is > > always on. Description suggests you want to instruct OS to do something. > > > > Again, third time (once from Bjorn, once from Dmitry), rephrase property > > name and description to describe the hardware issue. I see description > > improved, but not the property name. Again in the end of description you > > Both bjorn and Dmitry gave comments to change the description only, and not > the property name, > > correct if I am wrong. > > > say what Linux should do. Bindings do not describe Linux OS. > > I will remove the last line in the next patch. > You should name the property as, "qcom,keep-refclk-always-on" Also, no need to stuff the binding with "why this property is required", that info should be part of the patch description. Just describe what this property means in binding. - Mani > - Krishna Chaitanya. > > > > > Best regards, > > Krzysztof > -- மணிவண்ணன் சதாசிவம்