devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Paul Burton <paulburton@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
	"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Gregory CLEMENT" <gregory.clement@bootlin.com>
Subject: [PATCH v3 13/22] MIPS: traps: Give more explanations if ebase doesn't belong to KSEG0
Date: Fri,  1 Dec 2023 12:14:56 +0100	[thread overview]
Message-ID: <20231201111512.803120-14-gregory.clement@bootlin.com> (raw)
In-Reply-To: <20231201111512.803120-1-gregory.clement@bootlin.com>

Now that we support having the kernel in XPHYS and not only in KSEG0,
the case where ebase doesn't belong to KSEG0 is more likely to
occur. However, in this scenariowe encounter a significant and
intimidating stack dump without any explanation. To address this, we
should eliminate the uninformative stack dump and replace it with a
warning that provides a clear explanation of the issue.

Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
 arch/mips/kernel/traps.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 68f1dd54cde1c..3af2aa82b4408 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -2420,10 +2420,13 @@ void __init trap_init(void)
 		 * EVA is special though as it allows segments to be rearranged
 		 * and to become uncached during cache error handling.
 		 */
-		if (!IS_ENABLED(CONFIG_EVA) && !WARN_ON(ebase_pa >= 0x20000000))
+		if (!IS_ENABLED(CONFIG_EVA) && ebase_pa < 0x20000000)
 			ebase = CKSEG0ADDR(ebase_pa);
 		else
 			ebase = (unsigned long)phys_to_virt(ebase_pa);
+		if (ebase_pa >= 0x20000000)
+			pr_warn("ebase(0x%llX) should better be in KSeg0",
+				ebase_pa);
 	}
 
 	if (cpu_has_mmips) {
-- 
2.42.0


  parent reply	other threads:[~2023-12-01 11:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 11:14 [PATCH v3 00/22] Add support for the Mobileye EyeQ5 SoC Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 01/22] MIPS: compressed: Use correct instruction for 64 bit code Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 02/22] MIPS: Export higher/highest relocation functions in uasm Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 03/22] MIPS: spaces: Define a couple of handy macros Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 04/22] MIPS: genex: Fix except_vec_vi for kernel in XKPHYS Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 05/22] MIPS: Fix set_uncached_handler for ebase " Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 06/22] MIPS: Refactor mips_cps_core_entry implementation Gregory CLEMENT
2023-12-05 16:34   ` Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 07/22] MIPS: Fix cache issue with mips_cps_core_entry Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 08/22] MIPS: Allow kernel base to be set from Kconfig for all platforms Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 09/22] MIPS: traps: Handle CPU with non standard vint offset Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 10/22] MIPS: Avoid unnecessary reservation of exception space Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 11/22] MIPS: traps: Enhance memblock ebase allocation process Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 12/22] MIPS: Get rid of CONFIG_NO_EXCEPT_FILL Gregory CLEMENT
2023-12-06  0:40   ` kernel test robot
2023-12-01 11:14 ` Gregory CLEMENT [this message]
2023-12-01 11:14 ` [PATCH v3 14/22] dt-bindings: Add vendor prefix for Mobileye Vision Technologies Ltd Gregory CLEMENT
2023-12-01 11:14 ` [PATCH v3 15/22] dt-bindings: mips: cpus: Sort the entries Gregory CLEMENT
2023-12-01 12:03   ` Krzysztof Kozlowski
2023-12-01 12:31   ` Serge Semin
2023-12-01 11:14 ` [PATCH v3 16/22] dt-bindings: mips: cpu: Add I-Class I6500 Multiprocessor Core Gregory CLEMENT
2023-12-01 12:03   ` Krzysztof Kozlowski
2023-12-01 11:15 ` [PATCH v3 17/22] dt-bindings: mips: Add bindings for Mobileye SoCs Gregory CLEMENT
2023-12-01 11:15 ` [PATCH v3 18/22] dt-bindings: mfd: syscon: Document EyeQ5 OLB Gregory CLEMENT
2023-12-01 11:15 ` [PATCH v3 19/22] MIPS: mobileye: Add EyeQ5 dtsi Gregory CLEMENT
2023-12-01 11:15 ` [PATCH v3 20/22] MIPS: mobileye: Add EPM5 device tree Gregory CLEMENT
2023-12-01 11:15 ` [PATCH v3 21/22] MIPS: generic: Add support for Mobileye EyeQ5 Gregory CLEMENT
2023-12-01 11:47   ` Jiaxun Yang
2023-12-01 11:15 ` [PATCH v3 22/22] MAINTAINERS: Add entry for Mobileye MIPS SoCs Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231201111512.803120-14-gregory.clement@bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paulburton@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tawfik.bayouk@mobileye.com \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).