* [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type
@ 2023-12-01 12:39 Fabio Estevam
2023-12-01 12:39 ` [PATCH v2 2/3] media: dt-bindings: media: Introduce MEDIA_BUS_TYPE_DPI Fabio Estevam
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-12-01 12:39 UTC (permalink / raw)
To: sakari.ailus
Cc: rfoss, robh+dt, krzysztof.kozlowski+dt, conor+dt, mchehab,
laurent.pinchart, devicetree, linux-media, xji, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
bus-type = <7> is incorrect as this is a DSI endpoint, not a DPI
endpoint.
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Newly introduced.
.../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index a1ed1004651b..f043d57dd25a 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -157,7 +157,6 @@ examples:
reg = <0>;
anx7625_in: endpoint {
remote-endpoint = <&mipi_dsi>;
- bus-type = <7>;
data-lanes = <0 1 2 3>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/3] media: dt-bindings: media: Introduce MEDIA_BUS_TYPE_DPI
2023-12-01 12:39 [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type Fabio Estevam
@ 2023-12-01 12:39 ` Fabio Estevam
2023-12-01 12:39 ` [PATCH v2 3/3] media: dt-bindings: Use bus-types definitions from video-interfaces.h Fabio Estevam
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-12-01 12:39 UTC (permalink / raw)
To: sakari.ailus
Cc: rfoss, robh+dt, krzysztof.kozlowski+dt, conor+dt, mchehab,
laurent.pinchart, devicetree, linux-media, xji, Fabio Estevam,
Rob Herring, Laurent Pinchart
From: Fabio Estevam <festevam@denx.de>
Commit 18860529a599 ("media: dt-bindings: media: video-interfaces: Add
new bus-type") introduced a new bus-type for DPI video bus.
Introduce MEDIA_BUS_TYPE_DPI into video-interfaces.h to complete
the list of video interfaces.
Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
Changes since v1:
- Collected tags.
include/dt-bindings/media/video-interfaces.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
index 68ac4e05e37f..0dace694a18f 100644
--- a/include/dt-bindings/media/video-interfaces.h
+++ b/include/dt-bindings/media/video-interfaces.h
@@ -12,5 +12,6 @@
#define MEDIA_BUS_TYPE_CSI2_DPHY 4
#define MEDIA_BUS_TYPE_PARALLEL 5
#define MEDIA_BUS_TYPE_BT656 6
+#define MEDIA_BUS_TYPE_DPI 7
#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 3/3] media: dt-bindings: Use bus-types definitions from video-interfaces.h
2023-12-01 12:39 [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type Fabio Estevam
2023-12-01 12:39 ` [PATCH v2 2/3] media: dt-bindings: media: Introduce MEDIA_BUS_TYPE_DPI Fabio Estevam
@ 2023-12-01 12:39 ` Fabio Estevam
2023-12-01 15:41 ` [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type Conor Dooley
2023-12-04 4:09 ` Chen-Yu Tsai
3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-12-01 12:39 UTC (permalink / raw)
To: sakari.ailus
Cc: rfoss, robh+dt, krzysztof.kozlowski+dt, conor+dt, mchehab,
laurent.pinchart, devicetree, linux-media, xji, Fabio Estevam,
Rob Herring
From: Fabio Estevam <festevam@denx.de>
To improve readability, replace hardcoding numerical constants with the
corresponding definitions from video-interfaces.h.
Based on commit c4cfd47eb4ac ("media: dt-bindings: Use new video interface
bus type macros in examples").
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes since v1:
- Removed the analogix,anx7625.yaml change.
.../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
.../devicetree/bindings/media/i2c/toshiba,tc358746.yaml | 3 ++-
Documentation/devicetree/bindings/media/microchip,csi2dc.yaml | 4 +++-
.../devicetree/bindings/media/starfive,jh7110-camss.yaml | 4 +++-
.../devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml | 3 ++-
5 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index f043d57dd25a..19fbc6f67de8 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -132,6 +132,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
index 1c476b635b69..9e1874946017 100644
--- a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
@@ -129,6 +129,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c {
#address-cells = <1>;
@@ -161,7 +162,7 @@ examples:
remote-endpoint = <&sensor_out>;
hsync-active = <0>;
vsync-active = <0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
};
};
diff --git a/Documentation/devicetree/bindings/media/microchip,csi2dc.yaml b/Documentation/devicetree/bindings/media/microchip,csi2dc.yaml
index b3a345fc6464..2e694479d82d 100644
--- a/Documentation/devicetree/bindings/media/microchip,csi2dc.yaml
+++ b/Documentation/devicetree/bindings/media/microchip,csi2dc.yaml
@@ -142,6 +142,8 @@ examples:
# Example for connecting to a parallel sensor controller block (video pipe)
# and the input is received from Synopsys IDI interface
- |
+ #include <dt-bindings/media/video-interfaces.h>
+
csi2dc@e1404000 {
compatible = "microchip,sama7g5-csi2dc";
reg = <0xe1404000 0x500>;
@@ -154,7 +156,7 @@ examples:
port@0 {
reg = <0>; /* must be 0, first child port */
csi2dc_in: endpoint { /* input from IDI interface */
- bus-type = <4>; /* MIPI CSI2 D-PHY */
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
remote-endpoint = <&csi2host_out>;
};
};
diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
index c66586d90fa2..4964e59c3ae3 100644
--- a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
+++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
@@ -120,6 +120,8 @@ additionalProperties: false
examples:
- |
+ #include <dt-bindings/media/video-interfaces.h>
+
isp@19840000 {
compatible = "starfive,jh7110-camss";
reg = <0x19840000 0x10000>,
@@ -161,7 +163,7 @@ examples:
reg = <0>;
vin_from_sc2235: endpoint {
remote-endpoint = <&sc2235_to_vin>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
data-shift = <2>;
hsync-active = <1>;
diff --git a/Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml b/Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml
index f762fdc05e4d..5fdb9ae758e3 100644
--- a/Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml
+++ b/Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml
@@ -58,6 +58,7 @@ additionalProperties: false
examples:
- |
+ #include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/soc/ti,sci_pm_domain.h>
ti_csi2rx0: ticsi2rx@4500000 {
@@ -90,7 +91,7 @@ examples:
csi2rx0_in_sensor: endpoint {
remote-endpoint = <&csi2_cam0>;
- bus-type = <4>; /* CSI2 DPHY. */
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
clock-lanes = <0>;
data-lanes = <1 2>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type
2023-12-01 12:39 [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type Fabio Estevam
2023-12-01 12:39 ` [PATCH v2 2/3] media: dt-bindings: media: Introduce MEDIA_BUS_TYPE_DPI Fabio Estevam
2023-12-01 12:39 ` [PATCH v2 3/3] media: dt-bindings: Use bus-types definitions from video-interfaces.h Fabio Estevam
@ 2023-12-01 15:41 ` Conor Dooley
2023-12-04 4:09 ` Chen-Yu Tsai
3 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2023-12-01 15:41 UTC (permalink / raw)
To: Fabio Estevam
Cc: sakari.ailus, rfoss, robh+dt, krzysztof.kozlowski+dt, conor+dt,
mchehab, laurent.pinchart, devicetree, linux-media, xji,
Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]
On Fri, Dec 01, 2023 at 09:39:33AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> bus-type = <7> is incorrect as this is a DSI endpoint, not a DPI
> endpoint.
>
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Changes since v1:
> - Newly introduced.
>
> .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index a1ed1004651b..f043d57dd25a 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -157,7 +157,6 @@ examples:
> reg = <0>;
> anx7625_in: endpoint {
> remote-endpoint = <&mipi_dsi>;
> - bus-type = <7>;
> data-lanes = <0 1 2 3>;
> };
> };
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type
2023-12-01 12:39 [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type Fabio Estevam
` (2 preceding siblings ...)
2023-12-01 15:41 ` [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type Conor Dooley
@ 2023-12-04 4:09 ` Chen-Yu Tsai
3 siblings, 0 replies; 5+ messages in thread
From: Chen-Yu Tsai @ 2023-12-04 4:09 UTC (permalink / raw)
To: Fabio Estevam
Cc: sakari.ailus, rfoss, robh+dt, krzysztof.kozlowski+dt, conor+dt,
mchehab, laurent.pinchart, devicetree, linux-media, xji,
Fabio Estevam
On Fri, Dec 1, 2023 at 8:39 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> bus-type = <7> is incorrect as this is a DSI endpoint, not a DPI
> endpoint.
>
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-04 4:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-01 12:39 [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type Fabio Estevam
2023-12-01 12:39 ` [PATCH v2 2/3] media: dt-bindings: media: Introduce MEDIA_BUS_TYPE_DPI Fabio Estevam
2023-12-01 12:39 ` [PATCH v2 3/3] media: dt-bindings: Use bus-types definitions from video-interfaces.h Fabio Estevam
2023-12-01 15:41 ` [PATCH v2 1/3] dt-bindings: drm/bridge: anx7625: Remove incorrect bus-type Conor Dooley
2023-12-04 4:09 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox