* [PATCH] arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls
@ 2023-12-02 7:12 Sam Edwards
2023-12-02 16:36 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Sam Edwards @ 2023-12-02 7:12 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring
Cc: linux-rockchip, linux-arm-kernel, linux-kernel, devicetree,
Daniel Kukieła, Sven Rademakers, Lokesh Poovaragan,
Sam Edwards
The pinctrls for the hym8563 interrupt line and fan-tach input
were both mistakenly defined as `pcfg_pull_none`. As these are
active-low signals (level-triggered, in the hym8563 case) which
may not be driven at times, these should really be pull-up. The
lack of any bias results in spurious interrupts.
Fix this by modifying the `rockchip,pins` properties as necessary
to enable the pull-up resistors.
Fixes: 2806a69f3fef6 ("arm64: dts: rockchip: Add Turing RK1 SoM support")
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi
index b517debf2b54..bbb6d38cd159 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi
@@ -294,13 +294,13 @@ &pcie3x4 {
&pinctrl {
fan {
fan_int: fan-int {
- rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>;
+ rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>;
};
};
hym8563 {
hym8563_int: hym8563-int {
- rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
};
};
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls
2023-12-02 7:12 [PATCH] arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls Sam Edwards
@ 2023-12-02 16:36 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2023-12-02 16:36 UTC (permalink / raw)
To: Rob Herring, Sam Edwards
Cc: Heiko Stuebner, devicetree, Sven Rademakers, Sam Edwards,
linux-arm-kernel, Daniel Kukieła, Lokesh Poovaragan,
linux-rockchip, linux-kernel
On Fri, 1 Dec 2023 23:12:12 -0800, Sam Edwards wrote:
> The pinctrls for the hym8563 interrupt line and fan-tach input
> were both mistakenly defined as `pcfg_pull_none`. As these are
> active-low signals (level-triggered, in the hym8563 case) which
> may not be driven at times, these should really be pull-up. The
> lack of any bias results in spurious interrupts.
>
> Fix this by modifying the `rockchip,pins` properties as necessary
> to enable the pull-up resistors.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls
commit: 9f6acd2b4dfef81dcc45486ac704cf602c88db02
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-02 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-02 7:12 [PATCH] arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls Sam Edwards
2023-12-02 16:36 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox