* [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Drop incomplete example
@ 2023-11-28 21:48 Rob Herring
2023-11-29 8:30 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2023-11-28 21:48 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Krzysztof Kozlowski,
Conor Dooley, Tony Lindgren
Cc: linux-iio, devicetree, linux-kernel
The example for the TI Palmas ADC is incomplete as the binding is the
full PMIC, not just the sub-functions. It is preferred for MFD examples
to be complete in the top-level MFD device binding rather than piecemeal
in each sub-function binding.
This also fixes an undocumented (by schema) compatible warning for
'"ti,twl6035-pmic", "ti,palmas-pmic"'.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/iio/adc/ti,palmas-gpadc.yaml | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
index 720c16a108d4..f94057d8f605 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
@@ -67,19 +67,4 @@ required:
- compatible
- "#io-channel-cells"
-examples:
- - |
- #include <dt-bindings/clock/mt8183-clk.h>
- pmic {
- compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
- adc {
- compatible = "ti,palmas-gpadc";
- interrupts = <18 0>,
- <16 0>,
- <17 0>;
- #io-channel-cells = <1>;
- ti,channel0-current-microamp = <5>;
- ti,channel3-current-microamp = <10>;
- };
- };
...
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Drop incomplete example
2023-11-28 21:48 [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Drop incomplete example Rob Herring
@ 2023-11-29 8:30 ` Krzysztof Kozlowski
2023-12-04 13:23 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-29 8:30 UTC (permalink / raw)
To: Rob Herring, Jonathan Cameron, Lars-Peter Clausen,
Krzysztof Kozlowski, Conor Dooley, Tony Lindgren
Cc: linux-iio, devicetree, linux-kernel
On 28/11/2023 22:48, Rob Herring wrote:
> The example for the TI Palmas ADC is incomplete as the binding is the
> full PMIC, not just the sub-functions. It is preferred for MFD examples
> to be complete in the top-level MFD device binding rather than piecemeal
> in each sub-function binding.
>
> This also fixes an undocumented (by schema) compatible warning for
> '"ti,twl6035-pmic", "ti,palmas-pmic"'.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Drop incomplete example
2023-11-29 8:30 ` Krzysztof Kozlowski
@ 2023-12-04 13:23 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2023-12-04 13:23 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Lars-Peter Clausen, Krzysztof Kozlowski,
Conor Dooley, Tony Lindgren, linux-iio, devicetree, linux-kernel
On Wed, 29 Nov 2023 09:30:23 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 28/11/2023 22:48, Rob Herring wrote:
> > The example for the TI Palmas ADC is incomplete as the binding is the
> > full PMIC, not just the sub-functions. It is preferred for MFD examples
> > to be complete in the top-level MFD device binding rather than piecemeal
> > in each sub-function binding.
> >
> > This also fixes an undocumented (by schema) compatible warning for
> > '"ti,twl6035-pmic", "ti,palmas-pmic"'.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
Applied to the togreg branch of iio.git and pushed out as testing
for all the normal reasons.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-04 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 21:48 [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Drop incomplete example Rob Herring
2023-11-29 8:30 ` Krzysztof Kozlowski
2023-12-04 13:23 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).