devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: nuno.sa@analog.com
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add LTC4282 bindings
Date: Tue, 5 Dec 2023 16:18:14 +0000	[thread overview]
Message-ID: <20231205-cognitive-propose-aa71278f65ea@spud> (raw)
In-Reply-To: <20231205-ltc4282-support-v3-1-e0877b281bc2@analog.com>

[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]

On Tue, Dec 05, 2023 at 04:22:55PM +0100, Nuno Sa via B4 Relay wrote:

> +  adi,overvoltage-dividers:
> +    description: |
> +      Select which dividers to use for VDD Overvoltage detection. Note that
> +      when the internal dividers are used the threshold is referenced to VDD.
> +      The percentages in the datasheet are misleading since the actual values
> +      to look for are in the "Absolute Maximum Ratings" table in the
> +      "Comparator Inputs" section. In there there's a line for each of the 5%,
> +      10% and 15% settings with the actual min, typical and max tolerances.
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [external, vdd_5_percent, vdd_10_percent, vdd_15_percent]
> +
> +  adi,undervoltage-dividers:
> +    description: |
> +      Select which dividers to use for VDD Overvoltage detection. Note that
> +      when the internal dividers are used the threshold is referenced to VDD.
> +      The percentages in the datasheet are misleading since the actual values
> +      to look for are in the "Absolute Maximum Ratings" table in the
> +      "Comparator Inputs" section. In there there's a line for each of the 5%,
> +      10% and 15% settings with the actual min, typical and max tolerances.
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [external, vdd_5_percent, vdd_10_percent, vdd_15_percent]

> +  adi,gpio1-mode:
> +    description: Defines the function of the Pin. It can indicate that power is
> +      good (PULL the pin low when power is not good) or that power is bad (Go
> +      into high-z when power is not good).
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [power_bad, power_good]
> +
> +  adi,gpio2-mode:
> +    description: Defines the function of the Pin. It can be set as the input for
> +      the ADC or indicating that the MOSFET is in stress (dissipating power).
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [adc_input, stress_fet]

None of these properties have a default nor are required.
What happens when they are omitted?

Thanks,
Conor.

> +
> +required:
> +  - compatible
> +  - reg
> +  - adi,rsense-nano-ohms

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-12-05 16:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 15:22 [PATCH v3 0/2] Add support for LTC4282 Nuno Sa via B4 Relay
2023-12-05 15:22 ` [PATCH v3 1/2] dt-bindings: hwmon: Add LTC4282 bindings Nuno Sa via B4 Relay
2023-12-05 16:18   ` Conor Dooley [this message]
2023-12-06  8:38     ` Nuno Sá
2023-12-06 15:41       ` Conor Dooley
2023-12-05 15:22 ` [PATCH v3 2/2] hwmon: ltc4282: add support for the LTC4282 chip Nuno Sa via B4 Relay
2023-12-11 15:36   ` Guenter Roeck
2023-12-12 14:28     ` Nuno Sá
2023-12-12 15:14       ` Guenter Roeck
2023-12-12 15:30         ` Nuno Sá
2023-12-12 17:59           ` Guenter Roeck
2023-12-13 10:06             ` Nuno Sá
2023-12-13 14:35               ` Guenter Roeck
2023-12-13 14:44                 ` Nuno Sá
2023-12-11 15:41   ` Guenter Roeck
2023-12-12 13:53     ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231205-cognitive-propose-aa71278f65ea@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nuno.sa@analog.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).