[PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

[PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

[João Rodrigues]

From: João Rodrigues <jrodrigues@ubimet.com>

TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
The two sensors use different I2C addresses, so we can set both sensors
simultaneously.

Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
---
 arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
index fe42b0a4683..3fc3130f9de 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
@@ -128,11 +128,16 @@ vgen6_reg: vldo4 {
 		};
 	};
 
-	/* NXP SE97BTP with temperature sensor + eeprom */
+	/* LM75A temperature sensor, TQMa7x 01xx */
+	lm75a: temperature-sensor@48 {
+		compatible = "national,lm75a";
+		reg = <0x48>;
+	};
+
+	/* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
 	se97b: temperature-sensor-eeprom@1e {
 		compatible = "nxp,se97b", "jedec,jc-42.4-temp";
 		reg = <0x1e>;
-		status = "okay";
 	};
 
 	/* ST M24C64 */
-- 
2.25.1

Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

[Fabio Estevam]

[Adding Bruno and Alexander]

On Thu, Nov 2, 2023 at 7:12 PM João Rodrigues <jrodrigues@ubimet.com> wrote:
>
> From: João Rodrigues <jrodrigues@ubimet.com>
>
> TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> The two sensors use different I2C addresses, so we can set both sensors
> simultaneously.
>
> Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> index fe42b0a4683..3fc3130f9de 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> @@ -128,11 +128,16 @@ vgen6_reg: vldo4 {
>                 };
>         };
>
> -       /* NXP SE97BTP with temperature sensor + eeprom */
> +       /* LM75A temperature sensor, TQMa7x 01xx */
> +       lm75a: temperature-sensor@48 {
> +               compatible = "national,lm75a";
> +               reg = <0x48>;
> +       };
> +
> +       /* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
>         se97b: temperature-sensor-eeprom@1e {
>                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>                 reg = <0x1e>;
> -               status = "okay";
>         };
>
>         /* ST M24C64 */
> --
> 2.25.1
>

Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

[Alexander Stein]

Hi,

Am Freitag, 3. November 2023, 22:07:08 CET schrieb Fabio Estevam:
> [Adding Bruno and Alexander]
> 
> On Thu, Nov 2, 2023 at 7:12 PM João Rodrigues <jrodrigues@ubimet.com> wrote:
> > From: João Rodrigues <jrodrigues@ubimet.com>
> > 
> > TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> > The two sensors use different I2C addresses, so we can set both sensors
> > simultaneously.

I've contacted responsible department and I am waiting for more details.

Best regards,
Alexander

> > Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> > ---
> > 
> >  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi index
> > fe42b0a4683..3fc3130f9de 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > @@ -128,11 +128,16 @@ vgen6_reg: vldo4 {
> > 
> >                 };
> >         
> >         };
> > 
> > -       /* NXP SE97BTP with temperature sensor + eeprom */
> > +       /* LM75A temperature sensor, TQMa7x 01xx */
> > +       lm75a: temperature-sensor@48 {
> > +               compatible = "national,lm75a";
> > +               reg = <0x48>;
> > +       };
> > +
> > +       /* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
> > 
> >         se97b: temperature-sensor-eeprom@1e {
> >         
> >                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
> >                 reg = <0x1e>;
> > 
> > -               status = "okay";
> > 
> >         };
> >         
> >         /* ST M24C64 */
> > 
> > --
> > 2.25.1


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

[Bruno Thomsen]

Den fre. 3. nov. 2023 kl. 22.07 skrev Fabio Estevam <festevam@gmail.com>:
>
> [Adding Bruno and Alexander]
>
> On Thu, Nov 2, 2023 at 7:12 PM João Rodrigues <jrodrigues@ubimet.com> wrote:
> >
> > From: João Rodrigues <jrodrigues@ubimet.com>
> >
> > TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> > The two sensors use different I2C addresses, so we can set both sensors
> > simultaneously.

Hi João,

Looks correct to me and an elegant way of adding support for rev 01xx boards.

Reviewed-by: Bruno Thomsen <bruno.thomsen@gmail.com>

After this change the imx7d-flex-concentrator.dts needs to be updated
as it uses TQMa7d rev 02xx boards with something like this:

/* TQMa7d 02xx */
&se97b {
        status = "okay";
};

I can send a follow up patch when this change lands.

/Bruno

> >
> > Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> > ---
> >  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > index fe42b0a4683..3fc3130f9de 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > @@ -128,11 +128,16 @@ vgen6_reg: vldo4 {
> >                 };
> >         };
> >
> > -       /* NXP SE97BTP with temperature sensor + eeprom */
> > +       /* LM75A temperature sensor, TQMa7x 01xx */
> > +       lm75a: temperature-sensor@48 {
> > +               compatible = "national,lm75a";
> > +               reg = <0x48>;
> > +       };
> > +
> > +       /* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
> >         se97b: temperature-sensor-eeprom@1e {
> >                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
> >                 reg = <0x1e>;
> > -               status = "okay";
> >         };
> >
> >         /* ST M24C64 */
> > --
> > 2.25.1
> >

Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

[Alexander Stein]

Hi João,

Am Dienstag, 7. November 2023, 07:34:32 CET schrieb Alexander Stein:
> Hi,
> 
> Am Freitag, 3. November 2023, 22:07:08 CET schrieb Fabio Estevam:
> > [Adding Bruno and Alexander]
> > 
> > On Thu, Nov 2, 2023 at 7:12 PM João Rodrigues <jrodrigues@ubimet.com> 
wrote:
> > > From: João Rodrigues <jrodrigues@ubimet.com>
> > > 
> > > TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> > > The two sensors use different I2C addresses, so we can set both sensors
> > > simultaneously.
> 
> I've contacted responsible department and I am waiting for more details.

I got response that REV.01xx was just a prototype and not released officially.

> Best regards,
> Alexander
> 
> > > Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> > > ---
> > > 
> > >  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
> > >  1 file changed, 7 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi index
> > > fe42b0a4683..3fc3130f9de 100644
> > > --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > @@ -128,11 +128,16 @@ vgen6_reg: vldo4 {
> > > 
> > >                 };
> > >         
> > >         };
> > > 
> > > -       /* NXP SE97BTP with temperature sensor + eeprom */
> > > +       /* LM75A temperature sensor, TQMa7x 01xx */
> > > +       lm75a: temperature-sensor@48 {
> > > +               compatible = "national,lm75a";
> > > +               reg = <0x48>;
> > > +       };

I don't like the idea of adding an i2c device for everybody. This restricts/
affects usage of i2c address 0x48 for all rev.02xx users, no?

Best regards,
Alexander

> > > +
> > > +       /* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
> > > 
> > >         se97b: temperature-sensor-eeprom@1e {
> > >         
> > >                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
> > >                 reg = <0x1e>;
> > > 
> > > -               status = "okay";
> > > 
> > >         };
> > >         
> > >         /* ST M24C64 */
> > > 
> > > --
> > > 2.25.1


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

[jrodrigues]

On Wed, 8 Nov 2023 23:51:11 +0100
Bruno Thomsen <bruno.thomsen@gmail.com> wrote:

> Den fre. 3. nov. 2023 kl. 22.07 skrev Fabio Estevam
> <festevam@gmail.com>:
> >
> > [Adding Bruno and Alexander]
> >
> > On Thu, Nov 2, 2023 at 7:12 PM João Rodrigues
> > <jrodrigues@ubimet.com> wrote:  
> > >
> > > From: João Rodrigues <jrodrigues@ubimet.com>
> > >
> > > TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> > > The two sensors use different I2C addresses, so we can set both
> > > sensors simultaneously.  
> 
> Hi João,
> 
> Looks correct to me and an elegant way of adding support for rev 01xx
> boards.
> 
> Reviewed-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> 
> After this change the imx7d-flex-concentrator.dts needs to be updated
> as it uses TQMa7d rev 02xx boards with something like this:
> 
> /* TQMa7d 02xx */
> &se97b {
>         status = "okay";
> };
> 
> I can send a follow up patch when this change lands.
> 
> /Bruno
> 

Hi Bruno,

Thank you for the review.
Taking the status out was a request from Krzysztof in the initial version of
the patch, since the default for status is "okay". I have also tested (and
confirmed) this works as expected, with the appropriate temperature sensor
being recognised by the kernel.

Kind regards,
João

> > >
> > > Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> > > ---
> > >  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
> > >  1 file changed, 7 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi index
> > > fe42b0a4683..3fc3130f9de 100644 ---
> > > a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi +++
> > > b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi @@ -128,11 +128,16 @@
> > > vgen6_reg: vldo4 { };
> > >         };
> > >
> > > -       /* NXP SE97BTP with temperature sensor + eeprom */
> > > +       /* LM75A temperature sensor, TQMa7x 01xx */
> > > +       lm75a: temperature-sensor@48 {
> > > +               compatible = "national,lm75a";
> > > +               reg = <0x48>;
> > > +       };
> > > +
> > > +       /* NXP SE97BTP with temperature sensor + eeprom, TQMa7x
> > > 02xx */ se97b: temperature-sensor-eeprom@1e {
> > >                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
> > >                 reg = <0x1e>;
> > > -               status = "okay";
> > >         };
> > >
> > >         /* ST M24C64 */
> > > --
> > > 2.25.1
> > >  

Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

[jrodrigues]

Hi Alexander,

On Thu, 09 Nov 2023 07:57:36 +0100
Alexander Stein <alexander.stein@ew.tq-group.com> wrote:

> Hi João,
> 
> Am Dienstag, 7. November 2023, 07:34:32 CET schrieb Alexander Stein:
> > Hi,
> > 
> > Am Freitag, 3. November 2023, 22:07:08 CET schrieb Fabio Estevam:  
> > > [Adding Bruno and Alexander]
> > > 
> > > On Thu, Nov 2, 2023 at 7:12 PM João Rodrigues
> > > <jrodrigues@ubimet.com>   
> wrote:
> > > > From: João Rodrigues <jrodrigues@ubimet.com>
> > > > 
> > > > TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> > > > The two sensors use different I2C addresses, so we can set both
> > > > sensors simultaneously.  
> > 
> > I've contacted responsible department and I am waiting for more
> > details.  
> 
> I got response that REV.01xx was just a prototype and not released
> officially.

But REV. 01xx was not an internal-only prototype. 
Furthermore, in the board manual,
https://www.tq-group.com/filedownloads/files/products/embedded/manuals/arm/carrierboard/MBa7x/MBa7x.UM.0101.pdf
section 4.1.2, the old version is still referenced.

> 
> > Best regards,
> > Alexander
> >   
> > > > Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> > > > ---
> > > > 
> > > >  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
> > > >  1 file changed, 7 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > > b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi index
> > > > fe42b0a4683..3fc3130f9de 100644
> > > > --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > > +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > > @@ -128,11 +128,16 @@ vgen6_reg: vldo4 {
> > > > 
> > > >                 };
> > > >         
> > > >         };
> > > > 
> > > > -       /* NXP SE97BTP with temperature sensor + eeprom */
> > > > +       /* LM75A temperature sensor, TQMa7x 01xx */
> > > > +       lm75a: temperature-sensor@48 {
> > > > +               compatible = "national,lm75a";
> > > > +               reg = <0x48>;
> > > > +       };  
> 
> I don't like the idea of adding an i2c device for everybody. This
> restricts/ affects usage of i2c address 0x48 for all rev.02xx users,
> no?

Yes, it restricts the usage of I2C address 0x48 in I2C1.
While I2C1 is not exclusive to the SoM, the TQMa7x manual states
"I2C1 is used for devices on the TQMa7x".
As a counterpoint, the MBa7x carrier board also uses I2C1.

> 
> Best regards,
> Alexander
> > > > +
> > > > +       /* NXP SE97BTP with temperature sensor + eeprom, TQMa7x
> > > > 02xx */
> > > > 
> > > >         se97b: temperature-sensor-eeprom@1e {
> > > >         
> > > >                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
> > > >                 reg = <0x1e>;
> > > > 
> > > > -               status = "okay";
> > > > 
> > > >         };
> > > >         
> > > >         /* ST M24C64 */
> > > > 
> > > > --
> > > > 2.25.1  
> 
> 

Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

[Shawn Guo]

On Thu, Nov 02, 2023 at 11:11:30PM +0100, João Rodrigues wrote:
> From: João Rodrigues <jrodrigues@ubimet.com>
> 
> TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> The two sensors use different I2C addresses, so we can set both sensors
> simultaneously.
> 
> Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>

Applied, thanks!