devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts
@ 2023-12-05 20:20 Fabio Estevam
  2023-12-06 11:03 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2023-12-05 20:20 UTC (permalink / raw)
  To: broonie
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, viorel.suman,
	linux-sound, devicetree, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Unlike i.MX8MP, i.MX93 has two XCVR interrupts.

Describe the two interrupts for the i.MX93 to fix the following
dt-schema warning:

imx93-11x11-evk.dtb: xcvr@42680000: interrupts: [[0, 203, 4], [0, 204, 4]] is too long
	from schema $id: http://devicetree.org/schemas/sound/fsl,xcvr.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../devicetree/bindings/sound/fsl,xcvr.yaml    | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
index 799b362ba498..2db69a953afa 100644
--- a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
+++ b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
@@ -38,7 +38,10 @@ properties:
       - const: txfifo
 
   interrupts:
-    maxItems: 1
+    items:
+      - description: WAKEUPMIX Audio XCVR Interrupt 1
+      - description: WAKEUPMIX Audio XCVR Interrupt 2
+    minItems: 1
 
   clocks:
     items:
@@ -78,6 +81,19 @@ required:
   - dma-names
   - resets
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx93-xcvr
+    then:
+      properties:
+        interrupts:
+          minItems: 2
+          maxItems: 2
+
 additionalProperties: false
 
 examples:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts
  2023-12-05 20:20 [PATCH] ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts Fabio Estevam
@ 2023-12-06 11:03 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-06 11:03 UTC (permalink / raw)
  To: Fabio Estevam, broonie
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, viorel.suman,
	linux-sound, devicetree, Fabio Estevam

On 05/12/2023 21:20, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Unlike i.MX8MP, i.MX93 has two XCVR interrupts.
> 
> Describe the two interrupts for the i.MX93 to fix the following
> dt-schema warning:
> 
> imx93-11x11-evk.dtb: xcvr@42680000: interrupts: [[0, 203, 4], [0, 204, 4]] is too long
> 	from schema $id: http://devicetree.org/schemas/sound/fsl,xcvr.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../devicetree/bindings/sound/fsl,xcvr.yaml    | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> index 799b362ba498..2db69a953afa 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> @@ -38,7 +38,10 @@ properties:
>        - const: txfifo
>  
>    interrupts:
> -    maxItems: 1
> +    items:
> +      - description: WAKEUPMIX Audio XCVR Interrupt 1
> +      - description: WAKEUPMIX Audio XCVR Interrupt 2
> +    minItems: 1
>  
>    clocks:
>      items:
> @@ -78,6 +81,19 @@ required:
>    - dma-names
>    - resets
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx93-xcvr
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 2
> +          maxItems: 2

Same comment as your lcdif. Why all devices support now two interrupts?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-06 11:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-05 20:20 [PATCH] ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts Fabio Estevam
2023-12-06 11:03 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).