devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: imx8mn-var-som-symphony: add vcc supply for PCA9534
@ 2023-11-07 15:50 Hugo Villeneuve
  2023-12-06  0:50 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Hugo Villeneuve @ 2023-11-07 15:50 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team
  Cc: hugo, Hugo Villeneuve, devicetree, linux-arm-kernel, linux-kernel

From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

The following warning is shown when probing device:

    pca953x 1-0020: supply vcc not found, using dummy regulator

Define a new fixed 3.3v regulator for carrier board peripherals,
enabled by mosfet switch Q2 after the SOM_3V3 supply rises (no software
control).

Add this new regulator as vcc supply to the PCA9534 to silence the warning.

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
Changes for V2:
- add peripherals regulator and update commit message for Q2 mosfet.

 .../boot/dts/freescale/imx8mn-var-som-symphony.dts     | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts
index a7a57442cb81..a6b94d1957c9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts
@@ -57,6 +57,15 @@ led {
 			linux,default-trigger = "heartbeat";
 		};
 	};
+
+	/* Peripherals supply, enabled by Q2 after SOM_3V3 rises. */
+	reg_per_3v3: regulator-peripheral-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "per_3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
 };
 
 &ethphy {
@@ -79,6 +88,7 @@ pca9534: gpio@20 {
 		interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
 		#gpio-cells = <2>;
 		wakeup-source;
+		vcc-supply = <&reg_per_3v3>;
 
 		/* USB 3.0 OTG (usbotg1) / SATA port switch, set to USB 3.0 */
 		usb3-sata-sel-hog {

base-commit: be3ca57cfb777ad820c6659d52e60bbdd36bf5ff
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] arm64: dts: imx8mn-var-som-symphony: add vcc supply for PCA9534
  2023-11-07 15:50 [PATCH v2] arm64: dts: imx8mn-var-som-symphony: add vcc supply for PCA9534 Hugo Villeneuve
@ 2023-12-06  0:50 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2023-12-06  0:50 UTC (permalink / raw)
  To: Hugo Villeneuve
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Hugo Villeneuve, devicetree, linux-arm-kernel, linux-kernel

On Tue, Nov 07, 2023 at 10:50:40AM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> The following warning is shown when probing device:
> 
>     pca953x 1-0020: supply vcc not found, using dummy regulator
> 
> Define a new fixed 3.3v regulator for carrier board peripherals,
> enabled by mosfet switch Q2 after the SOM_3V3 supply rises (no software
> control).
> 
> Add this new regulator as vcc supply to the PCA9534 to silence the warning.
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-06  0:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07 15:50 [PATCH v2] arm64: dts: imx8mn-var-som-symphony: add vcc supply for PCA9534 Hugo Villeneuve
2023-12-06  0:50 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).