[PATCH] ARM: dts: nxp: imx7d-pico: add cpu-supply nodes

[PATCH] ARM: dts: nxp: imx7d-pico: add cpu-supply nodes

[Lech Perczak]

The PICO-IMX7D SoM has the usual power supply configuration using
output sw1a of PF3000 PMIC, which was defined in downstream derivative
of linux-imx (see link) in the sources for "Android Things" devkit.
It is required to support CPU frequency scaling.

Map the respective "cpu-supply" nodes of each core to sw1a of the PMIC.

Enabling them causes cpufreq-dt, and imx-thermal drivers to probe
successfully, and CPU frequency scaling to function.

Link: https://android.googlesource.com/platform/hardware/bsp/kernel/nxp/imx-v4.1/+/o-iot-preview-5/arch/arm/boot/dts/imx7d-pico.dtsi#849

Cc: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
---
 arch/arm/boot/dts/nxp/imx/imx7d-pico.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx7d-pico.dtsi
index c5eefe89cd99..8d5037ac03c7 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7d-pico.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx7d-pico.dtsi
@@ -108,6 +108,14 @@ &clks {
 	assigned-clock-rates = <0>, <32768>;
 };
 
+&cpu0 {
+	cpu-supply = <&sw1a_reg>;
+};
+
+&cpu1 {
+	cpu-supply = <&sw1a_reg>;
+};
+
 &ecspi3 {
 	cs-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
 	pinctrl-names = "default";

base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86
-- 
2.39.2

Re: [PATCH] ARM: dts: nxp: imx7d-pico: add cpu-supply nodes

[Fabio Estevam]

Hi Lech,

On Fri, Nov 17, 2023 at 8:24 PM Lech Perczak <lech.perczak@gmail.com> wrote:
>
> The PICO-IMX7D SoM has the usual power supply configuration using
> output sw1a of PF3000 PMIC, which was defined in downstream derivative
> of linux-imx (see link) in the sources for "Android Things" devkit.
> It is required to support CPU frequency scaling.
>
> Map the respective "cpu-supply" nodes of each core to sw1a of the PMIC.
>
> Enabling them causes cpufreq-dt, and imx-thermal drivers to probe
> successfully, and CPU frequency scaling to function.

Yes, it makes sense, thanks:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Re: [PATCH] ARM: dts: nxp: imx7d-pico: add cpu-supply nodes

[Shawn Guo]

On Sat, Nov 18, 2023 at 12:23:52AM +0100, Lech Perczak wrote:
> The PICO-IMX7D SoM has the usual power supply configuration using
> output sw1a of PF3000 PMIC, which was defined in downstream derivative
> of linux-imx (see link) in the sources for "Android Things" devkit.
> It is required to support CPU frequency scaling.
> 
> Map the respective "cpu-supply" nodes of each core to sw1a of the PMIC.
> 
> Enabling them causes cpufreq-dt, and imx-thermal drivers to probe
> successfully, and CPU frequency scaling to function.
> 
> Link: https://android.googlesource.com/platform/hardware/bsp/kernel/nxp/imx-v4.1/+/o-iot-preview-5/arch/arm/boot/dts/imx7d-pico.dtsi#849
> 
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> 
> Signed-off-by: Lech Perczak <lech.perczak@gmail.com>

Applied, thanks!

Re: [PATCH] ARM: dts: nxp: imx7d-pico: add cpu-supply nodes

[Lech Perczak]

W dniu 2023-12-06 o 02:32, Shawn Guo pisze:
> On Sat, Nov 18, 2023 at 12:23:52AM +0100, Lech Perczak wrote:
>> The PICO-IMX7D SoM has the usual power supply configuration using
>> output sw1a of PF3000 PMIC, which was defined in downstream derivative
>> of linux-imx (see link) in the sources for "Android Things" devkit.
>> It is required to support CPU frequency scaling.
>>
>> Map the respective "cpu-supply" nodes of each core to sw1a of the PMIC.
>>
>> Enabling them causes cpufreq-dt, and imx-thermal drivers to probe
>> successfully, and CPU frequency scaling to function.
>>
>> Link: https://android.googlesource.com/platform/hardware/bsp/kernel/nxp/imx-v4.1/+/o-iot-preview-5/arch/arm/boot/dts/imx7d-pico.dtsi#849
>>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>>
>> Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
> Applied, thanks!

Hi Shawn,

Do you think this could be backported to stable later?
OpenWrt and Debian could then pick this change up - I have a pull 
request open in OpenWrt backporting this.

-- 
Pozdrawiam/With kind regards,
Lech Perczak

Re: [PATCH] ARM: dts: nxp: imx7d-pico: add cpu-supply nodes

[Fabio Estevam]

Hi Lech,

On Mon, Dec 11, 2023 at 7:41 PM Lech Perczak <lech.perczak@gmail.com> wrote:

> Hi Shawn,
>
> Do you think this could be backported to stable later?
> OpenWrt and Debian could then pick this change up - I have a pull
> request open in OpenWrt backporting this.

As your patch is not a bug fix, it does not qualify to be backported
to linux-stable.

Please check the stable kernel rules at:
https://github.com/torvalds/linux/blob/master/Documentation/process/stable-kernel-rules.rst