* [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on
@ 2023-11-23 10:48 Francesco Dolcini
2023-11-23 10:52 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Francesco Dolcini @ 2023-11-23 10:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: Stefan Eichenberger, devicetree, linux-arm-kernel, linux-kernel,
Francesco Dolcini
From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Make sure that the wifi regulator is always on. The wifi driver itself
puts the wifi module into suspend mode. If we cut the power the driver
will crash when resuming from suspend.
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
index 5ce5fbf2b38e..f69b0c17560a 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
@@ -82,12 +82,9 @@ reg_module_wifi: regulator-module-wifi {
pinctrl-0 = <&pinctrl_wifi_pdn>;
gpio = <&lsio_gpio1 28 GPIO_ACTIVE_HIGH>;
enable-active-high;
+ regulator-always-on;
regulator-name = "wifi_pwrdn_fake_regulator";
regulator-settling-time-us = <100>;
-
- regulator-state-mem {
- regulator-off-in-suspend;
- };
};
reg_pcie_switch: regulator-pcie-switch {
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on
2023-11-23 10:48 [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on Francesco Dolcini
@ 2023-11-23 10:52 ` Fabio Estevam
2023-11-23 10:56 ` Francesco Dolcini
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2023-11-23 10:52 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team,
Stefan Eichenberger, devicetree, linux-arm-kernel, linux-kernel,
Francesco Dolcini
Hi Francesco,
On Thu, Nov 23, 2023 at 7:48 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>
> Make sure that the wifi regulator is always on. The wifi driver itself
> puts the wifi module into suspend mode. If we cut the power the driver
> will crash when resuming from suspend.
>
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
I think this one deserves a Fixes tag.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on
2023-11-23 10:52 ` Fabio Estevam
@ 2023-11-23 10:56 ` Francesco Dolcini
2023-12-06 1:48 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Francesco Dolcini @ 2023-11-23 10:56 UTC (permalink / raw)
To: Fabio Estevam, Shawn Guo
Cc: Francesco Dolcini, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team,
Stefan Eichenberger, devicetree, linux-arm-kernel, linux-kernel,
Francesco Dolcini
Hello Fabio,
On Thu, Nov 23, 2023 at 07:52:27AM -0300, Fabio Estevam wrote:
> On Thu, Nov 23, 2023 at 7:48 AM Francesco Dolcini <francesco@dolcini.it> wrote:
> >
> > From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> >
> > Make sure that the wifi regulator is always on. The wifi driver itself
> > puts the wifi module into suspend mode. If we cut the power the driver
> > will crash when resuming from suspend.
> >
> > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> I think this one deserves a Fixes tag.
Fixes: ad0de4ceb706 ("arm64: dts: freescale: add initial apalis imx8 aka quadmax module support")
Shawn, I assume you could just pick the Fixes tag without me sending a
v2, if you disagree just speak-up.
Francesco
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on
2023-11-23 10:56 ` Francesco Dolcini
@ 2023-12-06 1:48 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2023-12-06 1:48 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team,
Stefan Eichenberger, devicetree, linux-arm-kernel, linux-kernel,
Francesco Dolcini
On Thu, Nov 23, 2023 at 11:56:39AM +0100, Francesco Dolcini wrote:
> Hello Fabio,
>
> On Thu, Nov 23, 2023 at 07:52:27AM -0300, Fabio Estevam wrote:
> > On Thu, Nov 23, 2023 at 7:48 AM Francesco Dolcini <francesco@dolcini.it> wrote:
> > >
> > > From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > >
> > > Make sure that the wifi regulator is always on. The wifi driver itself
> > > puts the wifi module into suspend mode. If we cut the power the driver
> > > will crash when resuming from suspend.
> > >
> > > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> >
> > I think this one deserves a Fixes tag.
>
> Fixes: ad0de4ceb706 ("arm64: dts: freescale: add initial apalis imx8 aka quadmax module support")
>
> Shawn, I assume you could just pick the Fixes tag without me sending a
> v2, if you disagree just speak-up.
Applied with the Fixes tag, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-06 1:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-23 10:48 [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on Francesco Dolcini
2023-11-23 10:52 ` Fabio Estevam
2023-11-23 10:56 ` Francesco Dolcini
2023-12-06 1:48 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).