* [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts
@ 2023-12-06 11:23 Fabio Estevam
2023-12-06 15:34 ` Conor Dooley
2023-12-06 21:53 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2023-12-06 11:23 UTC (permalink / raw)
To: marex
Cc: stefan, robh+dt, krzysztof.kozlowski+dt, conor+dt, dri-devel,
devicetree, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
i.MX23 has two LCDIF interrupts instead of a single one like other
i.MX devices.
Take this into account for properly describing the i.MX23 LCDIF
interrupts.
This fixes the following dt-schema warning:
imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Marek Vasut <marex@denx.de>
---
Changes since v1:
- Add missing else to limit the number of irqs for the other variants. (Krzysztof)
.../bindings/display/fsl,lcdif.yaml | 20 ++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index fc11ab5fc465..1c2be8d6f633 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -51,7 +51,10 @@ properties:
minItems: 1
interrupts:
- maxItems: 1
+ items:
+ - description: LCDIF DMA interrupt
+ - description: LCDIF Error interrupt
+ minItems: 1
power-domains:
maxItems: 1
@@ -131,6 +134,21 @@ allOf:
then:
required:
- power-domains
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx23-lcdif
+ then:
+ properties:
+ interrupts:
+ minItems: 2
+ maxItems: 2
+ else:
+ properties:
+ interrupts:
+ maxItems: 1
examples:
- |
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts
2023-12-06 11:23 [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts Fabio Estevam
@ 2023-12-06 15:34 ` Conor Dooley
2023-12-06 21:53 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2023-12-06 15:34 UTC (permalink / raw)
To: Fabio Estevam
Cc: marex, stefan, robh+dt, krzysztof.kozlowski+dt, conor+dt,
dri-devel, devicetree, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On Wed, Dec 06, 2023 at 08:23:37AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> i.MX23 has two LCDIF interrupts instead of a single one like other
> i.MX devices.
>
> Take this into account for properly describing the i.MX23 LCDIF
> interrupts.
>
> This fixes the following dt-schema warning:
>
> imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
> from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Marek Vasut <marex@denx.de>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts
2023-12-06 11:23 [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts Fabio Estevam
2023-12-06 15:34 ` Conor Dooley
@ 2023-12-06 21:53 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-12-06 21:53 UTC (permalink / raw)
To: Fabio Estevam
Cc: devicetree, conor+dt, dri-devel, krzysztof.kozlowski+dt, marex,
robh+dt, stefan, Fabio Estevam
On Wed, 06 Dec 2023 08:23:37 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> i.MX23 has two LCDIF interrupts instead of a single one like other
> i.MX devices.
>
> Take this into account for properly describing the i.MX23 LCDIF
> interrupts.
>
> This fixes the following dt-schema warning:
>
> imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
> from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> Changes since v1:
> - Add missing else to limit the number of irqs for the other variants. (Krzysztof)
>
> .../bindings/display/fsl,lcdif.yaml | 20 ++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts
@ 2023-12-05 18:47 Fabio Estevam
2023-12-05 21:24 ` Marek Vasut
2023-12-06 11:02 ` Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2023-12-05 18:47 UTC (permalink / raw)
To: marex
Cc: stefan, robh+dt, krzysztof.kozlowski+dt, conor+dt, dri-devel,
devicetree, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
i.MX23 has two LCDIF interrupts instead of a single one like other
i.MX devices.
Take this into account for properly describing the i.MX23 LCDIF
interrupts.
This fixes the following dt-schema warning:
imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Fix typo in commit log (i.MX23 has two LCDIF interrupts).
.../devicetree/bindings/display/fsl,lcdif.yaml | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index fc11ab5fc465..c4228b893766 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -51,7 +51,10 @@ properties:
minItems: 1
interrupts:
- maxItems: 1
+ items:
+ - description: LCDIF DMA interrupt
+ - description: LCDIF Error interrupt
+ minItems: 1
power-domains:
maxItems: 1
@@ -131,6 +134,17 @@ allOf:
then:
required:
- power-domains
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx23-lcdif
+ then:
+ properties:
+ interrupts:
+ minItems: 2
+ maxItems: 2
examples:
- |
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts
2023-12-05 18:47 Fabio Estevam
@ 2023-12-05 21:24 ` Marek Vasut
2023-12-06 11:02 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2023-12-05 21:24 UTC (permalink / raw)
To: Fabio Estevam
Cc: stefan, robh+dt, krzysztof.kozlowski+dt, conor+dt, dri-devel,
devicetree, Fabio Estevam
On 12/5/23 19:47, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> i.MX23 has two LCDIF interrupts instead of a single one like other
> i.MX devices.
>
> Take this into account for properly describing the i.MX23 LCDIF
> interrupts.
>
> This fixes the following dt-schema warning:
>
> imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
> from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Indeed
Reviewed-by: Marek Vasut <marex@denx.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts
2023-12-05 18:47 Fabio Estevam
2023-12-05 21:24 ` Marek Vasut
@ 2023-12-06 11:02 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-06 11:02 UTC (permalink / raw)
To: Fabio Estevam, marex
Cc: stefan, robh+dt, krzysztof.kozlowski+dt, conor+dt, dri-devel,
devicetree, Fabio Estevam
On 05/12/2023 19:47, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> i.MX23 has two LCDIF interrupts instead of a single one like other
> i.MX devices.
>
> Take this into account for properly describing the i.MX23 LCDIF
> interrupts.
>
> This fixes the following dt-schema warning:
>
> imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
> from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v1:
> - Fix typo in commit log (i.MX23 has two LCDIF interrupts).
>
> .../devicetree/bindings/display/fsl,lcdif.yaml | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index fc11ab5fc465..c4228b893766 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -51,7 +51,10 @@ properties:
> minItems: 1
>
> interrupts:
> - maxItems: 1
> + items:
> + - description: LCDIF DMA interrupt
> + - description: LCDIF Error interrupt
> + minItems: 1
>
> power-domains:
> maxItems: 1
> @@ -131,6 +134,17 @@ allOf:
> then:
> required:
> - power-domains
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,imx23-lcdif
> + then:
> + properties:
> + interrupts:
> + minItems: 2
> + maxItems: 2
Either missing else: or update of other variants to limit interrupts to 1.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-06 21:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-06 11:23 [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts Fabio Estevam
2023-12-06 15:34 ` Conor Dooley
2023-12-06 21:53 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2023-12-05 18:47 Fabio Estevam
2023-12-05 21:24 ` Marek Vasut
2023-12-06 11:02 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).