From: "Marek Behún" <kabel@kernel.org>
To: Sjoerd Simons <sjoerd@collabora.com>
Cc: kernel@collabora.com, stable@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>, Conor Dooley <conor+dt@kernel.org>,
Gregory Clement <gregory.clement@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: armada-3720-turris-mox: set irq type for RTC
Date: Thu, 7 Dec 2023 15:43:36 +0100 [thread overview]
Message-ID: <20231207154336.5bf6272e@dellmb> (raw)
In-Reply-To: <20231128213536.3764212-4-sjoerd@collabora.com>
On Tue, 28 Nov 2023 22:35:06 +0100
Sjoerd Simons <sjoerd@collabora.com> wrote:
> The rtc on the mox shares its interrupt line with the moxtet bus. Set
> the interrupt type to be consistent between both devices. This ensures
> correct setup of the interrupt line regardless of probing order.
>
> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> Cc: stable@vger.kernel.org # v6.2+
> Fixes: 21aad8ba615e ("arm64: dts: armada-3720-turris-mox: Add missing interrupt for RTC")
>
> ---
>
> (no changes since v1)
>
> arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> index 9eab2bb22134..805ef2d79b40 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> @@ -130,7 +130,7 @@ rtc@6f {
> compatible = "microchip,mcp7940x";
> reg = <0x6f>;
> interrupt-parent = <&gpiosb>;
> - interrupts = <5 0>; /* GPIO2_5 */
> + interrupts = <5 IRQ_TYPE_EDGE_FALLING>; /* GPIO2_5 */
> };
> };
>
Reviewed-by: Marek Behún <kabel@kernel.org>
next prev parent reply other threads:[~2023-12-07 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 21:35 [PATCH v2 0/3] Moxtet bus fixes Sjoerd Simons
2023-11-28 21:35 ` [PATCH v2 3/3] arm64: dts: armada-3720-turris-mox: set irq type for RTC Sjoerd Simons
2023-12-07 14:43 ` Marek Behún [this message]
2023-12-08 14:51 ` [PATCH v2 0/3] Moxtet bus fixes Gregory CLEMENT
2023-12-08 15:17 ` Marek Behún
2023-12-15 14:47 ` Gregory CLEMENT
2023-12-15 15:16 ` Sjoerd Simons
2023-12-18 10:19 ` Sjoerd Simons
2023-12-20 13:55 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207154336.5bf6272e@dellmb \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sjoerd@collabora.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).