From: Rob Herring <robh@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Ard Biesheuvel <ardb@kernel.org>,
devicetree@vger.kernel.org, Sergio Lopez <slp@redhat.com>,
Sima Vetter <daniel.vetter@ffwll.ch>,
Hector Martin <marcan@marcan.st>,
Andrew Worsley <amworsley@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found
Date: Thu, 7 Dec 2023 11:30:37 -0600 [thread overview]
Message-ID: <20231207173037.GA2944721-robh@kernel.org> (raw)
In-Reply-To: <87zfyqvtpx.fsf@minerva.mail-host-address-is-not-set>
On Mon, Dec 04, 2023 at 05:05:30PM +0100, Javier Martinez Canillas wrote:
> Rob Herring <robh@kernel.org> writes:
>
> > On Mon, Dec 4, 2023 at 3:39 AM Javier Martinez Canillas
> > <javierm@redhat.com> wrote:
> >> Rob Herring <robh@kernel.org> writes:
> >> > On Fri, Dec 1, 2023 at 4:21 AM Javier Martinez Canillas
>
> [...]
>
> >>
> >> > However, there might be one other issue with that and this fix. The DT
> >> > simplefb can have resources such as clocks and regulators. With
> >> > fw_devlink, the driver won't probe until those dependencies are met.
> >> > So if you want the framebuffer console up early, then you may want to
> >> > register the EFI framebuffer first and then handoff to the DT simplefb
> >> > when it probes (rather than registering the device).
> >> >
> >> > But I agree, probably better to take this patch now and have those
> >> > quirks instead of flat out not working.
> >> >
> >>
> >> If we do that what's the plan? Are you thinking about merging this patch
> >> through your OF tree or do you want to go through drm-misc with your ack?
> >
> > I can take it. Do we need this in 6.7 and stable?
> >
>
> IMO this can wait for v6.8 since is not a fix for a change introduced in
> the v6.7 merge window and something that only happens on a very specific
> setup (DT systems booting with u-boot EFI and providing an EFI-GOP table).
>
> Also the -rc cycle is already in -rc5, so it seems risky to push a change
> at this point. And distros can pick the patch if want to have it earlier.
Okay, I've applied it for 6.8.
Rob
next prev parent reply other threads:[~2023-12-07 17:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 8:51 [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found Javier Martinez Canillas
2023-11-13 9:18 ` Thomas Zimmermann
2023-11-13 12:35 ` Andrew Worsley
2023-11-13 12:57 ` Javier Martinez Canillas
2023-11-13 13:19 ` Andrew Worsley
2023-11-15 20:34 ` Rob Herring
2023-11-16 9:36 ` Javier Martinez Canillas
2023-11-16 14:09 ` Rob Herring
2023-11-16 14:30 ` Ard Biesheuvel
2023-11-18 11:10 ` Javier Martinez Canillas
2023-11-23 8:49 ` Thomas Zimmermann
2023-12-01 10:21 ` Javier Martinez Canillas
2023-12-01 14:16 ` Rob Herring
2023-12-04 9:39 ` Javier Martinez Canillas
2023-12-04 14:05 ` Rob Herring
2023-12-04 16:05 ` Javier Martinez Canillas
2023-12-07 17:30 ` Rob Herring [this message]
2023-12-07 23:39 ` Javier Martinez Canillas
2023-11-16 14:40 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207173037.GA2944721-robh@kernel.org \
--to=robh@kernel.org \
--cc=amworsley@gmail.com \
--cc=ardb@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=slp@redhat.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).