From: Andreas Kemnade <andreas@kemnade.info>
To: Lee Jones <lee@kernel.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, bcousson@baylibre.com, tony@atomide.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 5/6] mfd: twl4030-power: accept standard property for power controller
Date: Fri, 8 Dec 2023 00:13:32 +0100 [thread overview]
Message-ID: <20231208001332.1f9e062f@aktux> (raw)
In-Reply-To: <20231207171341.GH111411@google.com>
On Thu, 7 Dec 2023 17:13:41 +0000
Lee Jones <lee@kernel.org> wrote:
> On Sun, 03 Dec 2023, Andreas Kemnade wrote:
>
> > Instead of only accepting the ti specific properties accept also
> > the standard property. For uniformity, search in the parent node
>
> Search 'in' the parent node or 'from' the parent node?
>
> Where is the property?
>
The idea was to have the device tree property at the same place for all
twl family devices. So no distinction for these devices needed
in the bindings. It is in the main node.
I guess today this twl4030-power subnode would not be accepted nowadays
and the compatible would be some kind of flag in the parent.
> > for the tag. The code for powering of is also isolated from the
>
> Should this be "off"?
>
yes, of course.
Regards,
Andreas
next prev parent reply other threads:[~2023-12-07 23:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 22:28 [PATCH v3 0/6] mfd: twl: system-power-controller Andreas Kemnade
2023-12-03 22:28 ` [PATCH v3 1/6] dt-bindings: mfd: ti,twl: Document system-power-controller Andreas Kemnade
2023-12-03 22:28 ` [PATCH v3 2/6] twl-core: add power off implementation for twl603x Andreas Kemnade
2023-12-07 17:11 ` Lee Jones
2023-12-07 18:11 ` Andreas Kemnade
2023-12-03 22:29 ` [PATCH v3 3/6] ARM: dts: omap-embt2ws: system-power-controller for bt200 Andreas Kemnade
2023-12-03 22:29 ` [PATCH v3 4/6] ARM: dts: omap4-panda-common: Enable powering off the device Andreas Kemnade
2023-12-03 22:29 ` [PATCH v3 5/6] mfd: twl4030-power: accept standard property for power controller Andreas Kemnade
2023-12-07 17:13 ` Lee Jones
2023-12-07 23:13 ` Andreas Kemnade [this message]
2023-12-03 22:29 ` [PATCH v3 6/6] ARM: dts: omap: gta04: standardize system-power-controller Andreas Kemnade
2023-12-03 22:46 ` Adam Ford
2023-12-04 22:27 ` Andreas Kemnade
2023-12-07 6:43 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208001332.1f9e062f@aktux \
--to=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).