From: Rob Herring <robh@kernel.org>
To: Peter Chiu <chui-hao.chiu@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Ryder Lee <ryder.Lee@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Sam Shih <sam.shih@mediatek.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
Date: Fri, 8 Dec 2023 10:27:29 -0600 [thread overview]
Message-ID: <20231208162729.GA1575094-robh@kernel.org> (raw)
In-Reply-To: <20231204091156.6535-1-chui-hao.chiu@mediatek.com>
On Mon, Dec 04, 2023 at 05:11:56PM +0800, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
>
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> ---
> v2: Change to use description instead of using items.
Not what I said to do...
Let me spell it out:
interrupts:
minItems: 1
items:
- description: major interrupt for rings
- description: addditional interrupt for ring 19
- description: addditional interrupt for ring 4
- description: addditional interrupt for ring 5
if:
properties:
compatible:
contains:
enum:
- mediatek,mt7986-wmac
then:
properties:
interrupts:
minItems: 4
else:
properties:
interrupts:
maxItems: 1
If there are 4 interrupts then you should always have all 4. It's not
some OS config. However, as an ABI, you might want to allow 1. If so,
then the if/then should just have the 'maxItems: 1' restriction for the
compatibles which only have 1 interrupt in the h/w.
Rob
prev parent reply other threads:[~2023-12-08 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 9:11 [PATCH v2] dt-bindings: net: wireless: mt76: add interrupts description for MT7986 Peter Chiu
2023-12-08 16:27 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208162729.GA1575094-robh@kernel.org \
--to=robh@kernel.org \
--cc=chui-hao.chiu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=ryder.Lee@mediatek.com \
--cc=sam.shih@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox