Re: [PATCH v2 4/4] media: i2c: add MAX96717 driver

[kernel test robot <lkp@intel.com>]

Hi Julien,

kernel test robot noticed the following build warnings:

[auto build test WARNING on media-tree/master]
[also build test WARNING on linuxtv-media-stage/master linus/master v6.7-rc4 next-20231208]
[cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Julien-Massot/dt-bindings-media-add-Maxim-MAX96714F-GMSL2-Deserializer/20231208-223758
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20231208143359.469049-5-julien.massot%40collabora.com
patch subject: [PATCH v2 4/4] media: i2c: add MAX96717 driver
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20231209/202312091123.dCDq07Qy-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231209/202312091123.dCDq07Qy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312091123.dCDq07Qy-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/i2c/max96717.c: In function 'max96717_set_fmt':
>> drivers/media/i2c/max96717.c:332:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     332 |         int ret;
         |             ^~~
   drivers/media/i2c/max96717.c: In function 'max96717_clk_set_rate':
   drivers/media/i2c/max96717.c:697:15: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     697 |         val = FIELD_PREP(REFGEN_PREDEF_FREQ_MASK,
         |               ^~~~~~~~~~
   drivers/media/i2c/max96717.c: In function 'max96717_init_csi_lanes':
   drivers/media/i2c/max96717.c:804:12: warning: 'ret' is used uninitialized [-Wuninitialized]
     804 |         if (ret)
         |            ^
   drivers/media/i2c/max96717.c:798:13: note: 'ret' was declared here
     798 |         int ret;
         |             ^~~
   cc1: some warnings being treated as errors


vim +/ret +332 drivers/media/i2c/max96717.c

   325	
   326	static int max96717_set_fmt(struct v4l2_subdev *sd,
   327				    struct v4l2_subdev_state *state,
   328				    struct v4l2_subdev_format *format)
   329	{
   330		struct max96717_priv *priv = sd_to_max96717(sd);
   331		struct v4l2_mbus_framefmt *fmt;
 > 332		int ret;
   333		u64 stream_source_mask;
   334	
   335		if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE &&
   336		    priv->enabled_source_streams)
   337			return -EBUSY;
   338	
   339		/* No transcoding, source and sink formats must match. */
   340		if (format->pad == MAX96717_PAD_SOURCE)
   341			return v4l2_subdev_get_fmt(sd, state, format);
   342	
   343		/* Set sink format */
   344		fmt = v4l2_subdev_state_get_format(state, format->pad, format->stream);
   345		if (!fmt)
   346			return -EINVAL;
   347	
   348		*fmt = format->format;
   349	
   350		/* Propagate to source format */
   351		fmt = v4l2_subdev_state_get_opposite_stream_format(state, format->pad,
   352								   format->stream);
   353		if (!fmt)
   354			return -EINVAL;
   355		*fmt = format->format;
   356	
   357		stream_source_mask = BIT(format->stream);
   358		ret = v4l2_subdev_state_xlate_streams(state, MAX96717_PAD_SOURCE,
   359						      MAX96717_PAD_SINK,
   360						      &stream_source_mask);
   361		return 0;
   362	}
   363	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki