From: Conor Dooley <conor@kernel.org>
To: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
Cc: Xingyu Wu <xingyu.wu@starfivetech.com>,
Samin Guo <samin.guo@starfivetech.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Ley Foon Tan <leyfoon.tan@starfivetech.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100
Date: Tue, 12 Dec 2023 16:47:59 +0000 [thread overview]
Message-ID: <20231212-shout-bazooka-714aeda42ec1@spud> (raw)
In-Reply-To: <20231212-reverb-daisy-4574734ae84f@spud>
[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]
On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:
> On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > watchdog.
> > Since JH8100 watchdog only has 1 reset signal, update binding
> > document to support one reset for "starfive,jh8100-wdt" compatible.
> >
> > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> > ---
> > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > index 68f3f6fd08a6..02572b16ac08 100644
> > --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > @@ -27,6 +27,7 @@ properties:
> > enum:
> > - starfive,jh7100-wdt
> > - starfive,jh7110-wdt
> > + - starfive,jh8100-wdt
> >
> > reg:
> > maxItems: 1
> > @@ -45,6 +46,7 @@ properties:
> > - const: core
> >
> > resets:
> > + minItems: 1
> > items:
> > - description: APB reset
> > - description: Core reset
>
> This relaxes the constraints for the existing devices, please add per
> compatible constraints to avoid doing so.
Also, you do not appear to have implemented the request from Krzysztof
to express compatibility with the jh7110.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-12 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 3:17 [PATCH v2 0/1] Add StarFive JH8100 watchdog Ji Sheng Teoh
2023-12-12 3:17 ` [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Ji Sheng Teoh
2023-12-12 16:46 ` Conor Dooley
2023-12-12 16:47 ` Conor Dooley [this message]
2023-12-13 2:57 ` Ji Sheng Teoh
2023-12-13 16:35 ` Conor Dooley
2023-12-14 5:17 ` Ji Sheng Teoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212-shout-bazooka-714aeda42ec1@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jisheng.teoh@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).