From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC5A47A234; Tue, 12 Dec 2023 16:48:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eFYe3wPM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A676C433C7; Tue, 12 Dec 2023 16:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702399684; bh=aNHGA0+OP2YXIV3jh4hVPbn2PRXP966VFGwAlUTm6OE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eFYe3wPMn3Lg3ndIIfcU5/QNd4Hro7G6QeuPLJluyf9mGilUtpinEgnsnB+fDHv+D 7l/2bca7V3e5KvIzg/hfVHk4ZSqfZDNDnzEgF0BV6B3DdcYxGNXRL/CPyQtuNsJddh MzflMEUzxV1Hjt+tk6kWy4IoUjd+3xgAw3/mAtA5YasDuIIQmi77Vaho3sgMTkKyjL 4Qh97xnK4IZH/FOZVFrwn4RClguppq0gSuG0kXGhcs/yzsNahmIM9tHOon1OJc6nbu MA7ep0eoK2Vz25gl0AQNtSgye3/5yRtw8vlwpzIGxAnCx61hHaVUF/92fjbLPQuWeD K+wAFGSyStZLA== Date: Tue, 12 Dec 2023 16:47:59 +0000 From: Conor Dooley To: Ji Sheng Teoh Cc: Xingyu Wu , Samin Guo , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ley Foon Tan , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Message-ID: <20231212-shout-bazooka-714aeda42ec1@spud> References: <20231212031731.2498584-1-jisheng.teoh@starfivetech.com> <20231212031731.2498584-2-jisheng.teoh@starfivetech.com> <20231212-reverb-daisy-4574734ae84f@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lo0V+T4OZHJunVRD" Content-Disposition: inline In-Reply-To: <20231212-reverb-daisy-4574734ae84f@spud> --lo0V+T4OZHJunVRD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote: > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote: > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100 > > watchdog. > > Since JH8100 watchdog only has 1 reset signal, update binding > > document to support one reset for "starfive,jh8100-wdt" compatible. > >=20 > > Signed-off-by: Ley Foon Tan > > Signed-off-by: Ji Sheng Teoh > > --- > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100= -wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.= yaml > > index 68f3f6fd08a6..02572b16ac08 100644 > > --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.ya= ml > > +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.ya= ml > > @@ -27,6 +27,7 @@ properties: > > enum: > > - starfive,jh7100-wdt > > - starfive,jh7110-wdt > > + - starfive,jh8100-wdt > > =20 > > reg: > > maxItems: 1 > > @@ -45,6 +46,7 @@ properties: > > - const: core > > =20 > > resets: > > + minItems: 1 > > items: > > - description: APB reset > > - description: Core reset >=20 > This relaxes the constraints for the existing devices, please add per > compatible constraints to avoid doing so. Also, you do not appear to have implemented the request from Krzysztof to express compatibility with the jh7110. --lo0V+T4OZHJunVRD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXiOvwAKCRB4tDGHoIJi 0herAQCODs736+Qe5j/hkbfNeI7xdVcGRKkurOrjX+4lQhNvpAEA6MN/UHKEuQ7A 3lki7S8WsCrF5mWZkZpNa9mg7laccgM= =4sul -----END PGP SIGNATURE----- --lo0V+T4OZHJunVRD--