* [PATCH v2 0/1] Add StarFive JH8100 watchdog @ 2023-12-12 3:17 Ji Sheng Teoh 2023-12-12 3:17 ` [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Ji Sheng Teoh 0 siblings, 1 reply; 7+ messages in thread From: Ji Sheng Teoh @ 2023-12-12 3:17 UTC (permalink / raw) To: Xingyu Wu, Samin Guo, Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Ji Sheng Teoh, Ley Foon Tan, linux-watchdog, devicetree, linux-kernel Changes since v1: - Drop "starfive,jh8100-wdt" compatible field in starfive-wdt.c, and express them in dt-bindings. - Use minItems in resets field to cater for single reset signal in JH8100. - Reword Watchdog reset to Core reset for JH8100. StarFive's JH8100 watchdog reuses JH7100 register mapping. DT-binding of JH7100 watchdog is extended to support JH8100. Since JH8100 only uses 1 reset signal, update the binding to support one reset for "starfive,jh8100-wdt" compatible. Ji Sheng Teoh (1): dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 2023-12-12 3:17 [PATCH v2 0/1] Add StarFive JH8100 watchdog Ji Sheng Teoh @ 2023-12-12 3:17 ` Ji Sheng Teoh 2023-12-12 16:46 ` Conor Dooley 0 siblings, 1 reply; 7+ messages in thread From: Ji Sheng Teoh @ 2023-12-12 3:17 UTC (permalink / raw) To: Xingyu Wu, Samin Guo, Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Ji Sheng Teoh, Ley Foon Tan, linux-watchdog, devicetree, linux-kernel Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100 watchdog. Since JH8100 watchdog only has 1 reset signal, update binding document to support one reset for "starfive,jh8100-wdt" compatible. Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> --- .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml index 68f3f6fd08a6..02572b16ac08 100644 --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml @@ -27,6 +27,7 @@ properties: enum: - starfive,jh7100-wdt - starfive,jh7110-wdt + - starfive,jh8100-wdt reg: maxItems: 1 @@ -45,6 +46,7 @@ properties: - const: core resets: + minItems: 1 items: - description: APB reset - description: Core reset -- 2.25.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 2023-12-12 3:17 ` [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Ji Sheng Teoh @ 2023-12-12 16:46 ` Conor Dooley 2023-12-12 16:47 ` Conor Dooley 0 siblings, 1 reply; 7+ messages in thread From: Conor Dooley @ 2023-12-12 16:46 UTC (permalink / raw) To: Ji Sheng Teoh Cc: Xingyu Wu, Samin Guo, Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ley Foon Tan, linux-watchdog, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1362 bytes --] On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote: > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100 > watchdog. > Since JH8100 watchdog only has 1 reset signal, update binding > document to support one reset for "starfive,jh8100-wdt" compatible. > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > --- > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > index 68f3f6fd08a6..02572b16ac08 100644 > --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > @@ -27,6 +27,7 @@ properties: > enum: > - starfive,jh7100-wdt > - starfive,jh7110-wdt > + - starfive,jh8100-wdt > > reg: > maxItems: 1 > @@ -45,6 +46,7 @@ properties: > - const: core > > resets: > + minItems: 1 > items: > - description: APB reset > - description: Core reset This relaxes the constraints for the existing devices, please add per compatible constraints to avoid doing so. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 2023-12-12 16:46 ` Conor Dooley @ 2023-12-12 16:47 ` Conor Dooley 2023-12-13 2:57 ` Ji Sheng Teoh 0 siblings, 1 reply; 7+ messages in thread From: Conor Dooley @ 2023-12-12 16:47 UTC (permalink / raw) To: Ji Sheng Teoh Cc: Xingyu Wu, Samin Guo, Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ley Foon Tan, linux-watchdog, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1612 bytes --] On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote: > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote: > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100 > > watchdog. > > Since JH8100 watchdog only has 1 reset signal, update binding > > document to support one reset for "starfive,jh8100-wdt" compatible. > > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > > --- > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > index 68f3f6fd08a6..02572b16ac08 100644 > > --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > @@ -27,6 +27,7 @@ properties: > > enum: > > - starfive,jh7100-wdt > > - starfive,jh7110-wdt > > + - starfive,jh8100-wdt > > > > reg: > > maxItems: 1 > > @@ -45,6 +46,7 @@ properties: > > - const: core > > > > resets: > > + minItems: 1 > > items: > > - description: APB reset > > - description: Core reset > > This relaxes the constraints for the existing devices, please add per > compatible constraints to avoid doing so. Also, you do not appear to have implemented the request from Krzysztof to express compatibility with the jh7110. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 2023-12-12 16:47 ` Conor Dooley @ 2023-12-13 2:57 ` Ji Sheng Teoh 2023-12-13 16:35 ` Conor Dooley 0 siblings, 1 reply; 7+ messages in thread From: Ji Sheng Teoh @ 2023-12-13 2:57 UTC (permalink / raw) To: conor Cc: conor+dt, devicetree, jisheng.teoh, krzysztof.kozlowski+dt, leyfoon.tan, linux-kernel, linux-watchdog, linux, robh+dt, samin.guo, wim, xingyu.wu On Tue, 12 Dec 2023 16:47:59 +0000 Conor Dooley <conor@kernel.org> wrote: > On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote: > > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote: > > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100 > > > watchdog. > > > Since JH8100 watchdog only has 1 reset signal, update binding > > > document to support one reset for "starfive,jh8100-wdt" > > > compatible. > > > > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > > > --- > > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > | 2 ++ 1 file changed, 2 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > index 68f3f6fd08a6..02572b16ac08 100644 --- > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > +++ > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > @@ -27,6 +27,7 @@ properties: enum: > > > - starfive,jh7100-wdt > > > - starfive,jh7110-wdt > > > + - starfive,jh8100-wdt > > > > > > reg: > > > maxItems: 1 > > > @@ -45,6 +46,7 @@ properties: > > > - const: core > > > > > > resets: > > > + minItems: 1 > > > items: > > > - description: APB reset > > > - description: Core reset > > > > This relaxes the constraints for the existing devices, please add > > per compatible constraints to avoid doing so. > Thanks Conor. Just to clarify, are you suggesting to add what was done in v1? v1: https://lore.kernel.org/all/20231209142723.2060196-3-jisheng.teoh@starfivetech.com/ > Also, you do not appear to have implemented the request from Krzysztof > to express compatibility with the jh7110. > Ok, fix that up. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 2023-12-13 2:57 ` Ji Sheng Teoh @ 2023-12-13 16:35 ` Conor Dooley 2023-12-14 5:17 ` Ji Sheng Teoh 0 siblings, 1 reply; 7+ messages in thread From: Conor Dooley @ 2023-12-13 16:35 UTC (permalink / raw) To: Ji Sheng Teoh Cc: conor+dt, devicetree, krzysztof.kozlowski+dt, leyfoon.tan, linux-kernel, linux-watchdog, linux, robh+dt, samin.guo, wim, xingyu.wu [-- Attachment #1: Type: text/plain, Size: 2121 bytes --] On Wed, Dec 13, 2023 at 10:57:59AM +0800, Ji Sheng Teoh wrote: > On Tue, 12 Dec 2023 16:47:59 +0000 > Conor Dooley <conor@kernel.org> wrote: > > > On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote: > > > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote: > > > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100 > > > > watchdog. > > > > Since JH8100 watchdog only has 1 reset signal, update binding > > > > document to support one reset for "starfive,jh8100-wdt" > > > > compatible. > > > > > > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > > > > --- > > > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > | 2 ++ 1 file changed, 2 insertions(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > index 68f3f6fd08a6..02572b16ac08 100644 --- > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > +++ > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > @@ -27,6 +27,7 @@ properties: enum: > > > > - starfive,jh7100-wdt > > > > - starfive,jh7110-wdt > > > > + - starfive,jh8100-wdt > > > > > > > > reg: > > > > maxItems: 1 > > > > @@ -45,6 +46,7 @@ properties: > > > > - const: core > > > > > > > > resets: > > > > + minItems: 1 > > > > items: > > > > - description: APB reset > > > > - description: Core reset > > > > > > This relaxes the constraints for the existing devices, please add > > > per compatible constraints to avoid doing so. > > > Thanks Conor. Just to clarify, are you suggesting to add what was done > in v1? > v1: > https://lore.kernel.org/all/20231209142723.2060196-3-jisheng.teoh@starfivetech.com/ No, but similar. Add numerical constraints that vary per SoC without changing the names of the resets on a per-SoC basis.:wq [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 2023-12-13 16:35 ` Conor Dooley @ 2023-12-14 5:17 ` Ji Sheng Teoh 0 siblings, 0 replies; 7+ messages in thread From: Ji Sheng Teoh @ 2023-12-14 5:17 UTC (permalink / raw) To: conor Cc: conor+dt, devicetree, jisheng.teoh, krzysztof.kozlowski+dt, leyfoon.tan, linux-kernel, linux-watchdog, linux, robh+dt, samin.guo, wim, xingyu.wu On Wed, 13 Dec 2023 16:35:39 +0000 Conor Dooley <conor@kernel.org> wrote: > On Wed, Dec 13, 2023 at 10:57:59AM +0800, Ji Sheng Teoh wrote: > > On Tue, 12 Dec 2023 16:47:59 +0000 > > Conor Dooley <conor@kernel.org> wrote: > > > > > On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote: > > > > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote: > > > > > > > > > Add "starfive,jh8100-wdt" compatible string for StarFive's > > > > > JH8100 watchdog. > > > > > Since JH8100 watchdog only has 1 reset signal, update binding > > > > > document to support one reset for "starfive,jh8100-wdt" > > > > > compatible. > > > > > > > > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > > > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > > > > > --- > > > > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > > | 2 ++ 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git > > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > > index 68f3f6fd08a6..02572b16ac08 100644 --- > > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > > +++ > > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > > > @@ -27,6 +27,7 @@ properties: enum: > > > > > - starfive,jh7100-wdt > > > > > - starfive,jh7110-wdt > > > > > + - starfive,jh8100-wdt > > > > > > > > > > reg: > > > > > maxItems: 1 > > > > > @@ -45,6 +46,7 @@ properties: > > > > > - const: core > > > > > > > > > > resets: > > > > > + minItems: 1 > > > > > items: > > > > > - description: APB reset > > > > > - description: Core reset > > > > > > > > This relaxes the constraints for the existing devices, please > > > > add per compatible constraints to avoid doing so. > > > > > Thanks Conor. Just to clarify, are you suggesting to add what was > > done in v1? > > v1: > > https://lore.kernel.org/all/20231209142723.2060196-3-jisheng.teoh@starfivetech.com/ > > > > No, but similar. Add numerical constraints that vary per SoC without > changing the names of the resets on a per-SoC basis.:wq > Sent out v3, hope it addresses the comments. v3: https://lore.kernel.org/all/20231214033056.3953143-2-jisheng.teoh@starfivetech.com/ ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-12-14 5:18 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-12-12 3:17 [PATCH v2 0/1] Add StarFive JH8100 watchdog Ji Sheng Teoh 2023-12-12 3:17 ` [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Ji Sheng Teoh 2023-12-12 16:46 ` Conor Dooley 2023-12-12 16:47 ` Conor Dooley 2023-12-13 2:57 ` Ji Sheng Teoh 2023-12-13 16:35 ` Conor Dooley 2023-12-14 5:17 ` Ji Sheng Teoh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).