From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="UnbSIH0Y" Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B5A583; Wed, 13 Dec 2023 01:59:50 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 40D6E240011; Wed, 13 Dec 2023 09:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1702461589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nTAnT1PVzX6vcK0RfwUZyNxxQAd/jwvrT19yLQs+C4Q=; b=UnbSIH0Y1HCLvwbULwx2H3B1LWY96fVr8vLzUfF1/SFv9nka4g4DdQJDAkDjs38Kwm7Atk mp872UwH9UE7oDt7zK1SxubMXoShq3w2Pf6m+cjSwM9ao27/SiTzLqo6hudA7QuKA9970g WLgHOC/5FRwEvcpYnSuJl2adqREKc1qWIfhSrEH3UKLlUyZNJqhX/qETogIopr1bq4EM8o paXnwt/VrPgrAuR6/J/miZPdF5CQfKhOi4JbzoXemoCK4cqva1TYYlUTSbwap+ZOdKVdxj aaB00qqbkN0rmExstwn1PdamLsNOfLzeb1N//3GTUIKOvxgUPuKgyzf4C/bdQg== Date: Wed, 13 Dec 2023 10:59:48 +0100 From: Kamel Bouhara To: Krzysztof Kozlowski Cc: Conor Dooley , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Marco Felsch , Jeff LaBundy , catalin.popescu@leica-geosystems.com, mark.satterthwaite@touchnetix.com, bartp@baasheep.co.uk, hannah.rossiter@touchnetix.com, Thomas Petazzoni , Gregory Clement , bsp-development.geo@leica-geosystems.com Subject: Re: [PATCH v5 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen Message-ID: <20231213095948.GD2340704@kb-xps> References: <20231211121430.1689139-1-kamel.bouhara@bootlin.com> <20231211121430.1689139-3-kamel.bouhara@bootlin.com> <20231212-rework-bounce-f4d9d12362a4@spud> <20231213082256.GB2340704@kb-xps> <656f2245-ff76-48cf-9a1f-05259765c622@linaro.org> <20231213091417.GC2340704@kb-xps> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-GND-Sasl: kamel.bouhara@bootlin.com Le Wed, Dec 13, 2023 at 10:15:35AM +0100, Krzysztof Kozlowski a écrit : > On 13/12/2023 10:14, Kamel Bouhara wrote: > > Le Wed, Dec 13, 2023 at 09:46:03AM +0100, Krzysztof Kozlowski a écrit : > >> On 13/12/2023 09:22, Kamel Bouhara wrote: > >>>> It still brings the type of some fields or the constraints. However need > >>>> of specifying "poll-interval" already points to missing > >>>> unevaluatedProperties. > >>> > >>> Ok, this wasn't clear for me wether or not I should pick > >>> unevaluatedProperties > >> > >> Yes > >> > >>> as I still reference "poll-interval" from the > >>> input.yaml schema ? > >> > >> You should drop it from your binding. > > > > The driver use it could you explain why I should drop it ? > > Because it comes from input.yaml and you did not add any constraints, so > poll-interval here is redundant. > Ok clear, thanks ! Regards, -- Kamel Bouhara, Bootlin Embedded Linux and kernel engineering https://bootlin.com