Re: [PATCH 2/3] bindings: hwmon: Add adi,adaq4224_temp as compatible string

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

On Thu, Dec 14, 2023 at 07:15:13AM -0800, Guenter Roeck wrote:
> On 12/14/23 06:36, Daniel Matyas wrote:
> > In the device ada4224 the max31827 temperature sensor will be used, so
> > the default values corresponding to adaq4224_temp are the same for
> > max31827.
> > 
> 
> I don't know what that device is, but if the max31827 is used it should
> be instantiated as max31827.

An improved commit message would be rather helpful here, as google did
not turn up any information on what this new device is.
Taking the patch on face value, a couple comments below.

> > Signed-off-by: Daniel Matyas <daniel.matyas@analog.com>
> > ---
> >   Documentation/devicetree/bindings/hwmon/adi,max31827.yaml | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> > index f60e06ab7d0a..9f3b0839aa46 100644
> > --- a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> > @@ -20,6 +20,7 @@ properties:
> >         - const: adi,max31827
> >         - items:
> >             - enum:
> > +              - adi,adaq4224_temp

No underscores in the compatible please.

> >                 - adi,max31828
> >                 - adi,max31829
> >             - const: adi,max31827
> > @@ -81,7 +82,9 @@ allOf:
> >         properties:
> >           compatible:
> >             contains:
> > -            const: adi,max31827
> > +            enum:
> > +              - adi,max31827
> > +              - adi,adaq4224_temp

This doesn't do anything afaict, since the binding doesn't allow
"adi,adaq4224_temp" without "adi,max31827".

> >       then:
> >         properties:
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]