From: Praveenkumar I <quic_ipkumar@quicinc.com>
To: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<bhelgaas@google.com>, <lpieralisi@kernel.org>, <kw@linux.com>,
<vkoul@kernel.org>, <kishon@kernel.org>, <mani@kernel.org>,
<quic_nsekar@quicinc.com>, <quic_srichara@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-phy@lists.infradead.org>
Cc: <quic_varada@quicinc.com>, <quic_devipriy@quicinc.com>,
<quic_kathirav@quicinc.com>, <quic_anusha@quicinc.com>
Subject: [PATCH 06/10] phy: qcom: ipq5332: Add support for g3x1 and g3x2 PCIe PHYs
Date: Thu, 14 Dec 2023 11:58:43 +0530 [thread overview]
Message-ID: <20231214062847.2215542-7-quic_ipkumar@quicinc.com> (raw)
In-Reply-To: <20231214062847.2215542-1-quic_ipkumar@quicinc.com>
Add support for single-lane and dual-lane PCIe UNIPHY found on
Qualcomm IPQ5332 platform. This UNIPHY is similar to the one
present in Qualcomm IPQ5018.
Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
---
This patch depends on the below series which adds PCIe support in
Qualcomm IPQ5018
https://lore.kernel.org/all/20231003120846.28626-1-quic_nsekar@quicinc.com/
.../phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c | 44 +++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c b/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c
index 9f9a03faf6fa..aa71b85eb50e 100644
--- a/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c
+++ b/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c
@@ -34,6 +34,10 @@
#define SSCG_CTRL_REG_6 0xb0
#define PCS_INTERNAL_CONTROL_2 0x2d8
+#define PHY_CFG_PLLCFG 0x220
+#define PHY_CFG_EIOS_DTCT_REG 0x3e4
+#define PHY_CFG_GEN3_ALIGN_HOLDOFF_TIME 0x3e8
+
#define PHY_MODE_FIXED 0x1
enum qcom_uniphy_pcie_type {
@@ -112,6 +116,21 @@ static const struct uniphy_regs ipq5018_regs[] = {
},
};
+static const struct uniphy_regs ipq5332_regs[] = {
+ {
+ .offset = PHY_CFG_PLLCFG,
+ .val = 0x30,
+ },
+ {
+ .offset = PHY_CFG_EIOS_DTCT_REG,
+ .val = 0x53ef,
+ },
+ {
+ .offset = PHY_CFG_GEN3_ALIGN_HOLDOFF_TIME,
+ .val = 0xCf,
+ },
+};
+
static const struct uniphy_pcie_data ipq5018_2x2_data = {
.lanes = 2,
.lane_offset = 0x800,
@@ -121,6 +140,23 @@ static const struct uniphy_pcie_data ipq5018_2x2_data = {
.pipe_clk_rate = 125000000,
};
+static const struct uniphy_pcie_data ipq5332_x2_data = {
+ .lanes = 2,
+ .lane_offset = 0x800,
+ .phy_type = PHY_TYPE_PCIE_GEN3,
+ .init_seq = ipq5332_regs,
+ .init_seq_num = ARRAY_SIZE(ipq5332_regs),
+ .pipe_clk_rate = 250000000,
+};
+
+static const struct uniphy_pcie_data ipq5332_x1_data = {
+ .lanes = 1,
+ .phy_type = PHY_TYPE_PCIE_GEN3,
+ .init_seq = ipq5332_regs,
+ .init_seq_num = ARRAY_SIZE(ipq5332_regs),
+ .pipe_clk_rate = 250000000,
+};
+
static void qcom_uniphy_pcie_init(struct qcom_uniphy_pcie *phy)
{
const struct uniphy_pcie_data *data = phy->data;
@@ -270,6 +306,14 @@ static const struct of_device_id qcom_uniphy_pcie_id_table[] = {
.compatible = "qcom,ipq5018-uniphy-pcie-gen2x2",
.data = &ipq5018_2x2_data,
},
+ {
+ .compatible = "qcom,ipq5332-uniphy-pcie-gen3x2",
+ .data = &ipq5332_x2_data,
+ },
+ {
+ .compatible = "qcom,ipq5332-uniphy-pcie-gen3x1",
+ .data = &ipq5332_x1_data,
+ },
{ /* Sentinel */ },
};
MODULE_DEVICE_TABLE(of, qcom_uniphy_pcie_id_table);
--
2.34.1
next prev parent reply other threads:[~2023-12-14 6:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 6:28 [PATCH 00/10] Add PCIe support for Qualcomm IPQ5332 Praveenkumar I
2023-12-14 6:28 ` [PATCH 01/10] dt-bindings: clock: Add separate clocks for PCIe and USB for Combo PHY Praveenkumar I
2023-12-15 8:28 ` Krzysztof Kozlowski
2023-12-14 6:28 ` [PATCH 02/10] clk: qcom: ipq5332: " Praveenkumar I
2023-12-14 7:09 ` Dmitry Baryshkov
2023-12-15 5:44 ` Praveenkumar I
2023-12-15 10:38 ` Dmitry Baryshkov
2023-12-14 6:28 ` [PATCH 03/10] arm64: dts: qcom: ipq5332: Add separate entry for USB pipe clock Praveenkumar I
2023-12-14 7:21 ` Dmitry Baryshkov
2023-12-15 5:58 ` Praveenkumar I
2023-12-14 6:28 ` [PATCH 04/10] phy: qcom: Add support for Pipe clock rate from device data Praveenkumar I
2023-12-14 7:12 ` Dmitry Baryshkov
2023-12-14 6:28 ` [PATCH 05/10] dt-bindings: phy: qcom,uniphy-pcie: Add ipq5332 bindings Praveenkumar I
2023-12-15 8:31 ` Krzysztof Kozlowski
2023-12-14 6:28 ` Praveenkumar I [this message]
2023-12-14 7:12 ` [PATCH 06/10] phy: qcom: ipq5332: Add support for g3x1 and g3x2 PCIe PHYs Dmitry Baryshkov
2023-12-15 5:45 ` Praveenkumar I
2023-12-14 6:28 ` [PATCH 07/10] dt-bindings: PCI: qcom: Add IPQ5332 SoC Praveenkumar I
2023-12-14 7:15 ` Dmitry Baryshkov
2023-12-15 5:52 ` Praveenkumar I
2023-12-15 8:35 ` Krzysztof Kozlowski
2023-12-14 6:28 ` [PATCH 08/10] pci: qcom: Add support for IPQ5332 Praveenkumar I
2023-12-14 7:20 ` Dmitry Baryshkov
2023-12-14 6:28 ` [PATCH 09/10] arm64: dts: qcom: ipq5332: Add PCIe related nodes Praveenkumar I
2023-12-15 8:36 ` Krzysztof Kozlowski
2023-12-14 6:28 ` [PATCH 10/10] arm64: dts: qcom: ipq5332: Enable PCIe phys and controllers Praveenkumar I
2024-03-10 13:29 ` [PATCH 00/10] Add PCIe support for Qualcomm IPQ5332 Manivannan Sadhasivam
2024-11-15 10:04 ` Sricharan Ramabadhran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214062847.2215542-7-quic_ipkumar@quicinc.com \
--to=quic_ipkumar@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).