devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org,
	sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH 01/16] dt-bindings: phy: qmp-ufs: Fix PHY clocks
Date: Thu, 14 Dec 2023 14:40:46 +0530	[thread overview]
Message-ID: <20231214091101.45713-2-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org>

All QMP UFS PHYs except MSM8996 require 3 clocks:

* ref - 19.2MHz reference clock from RPMh
* ref_aux - Auxiliary reference clock from GCC
* qref - QREF clock from GCC or TCSR (since SM8550)

MSM8996 only requires 'ref' and 'qref' clocks. Hence, fix the binding to
reflect the actual clock topology.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml        | 47 +++++++++----------
 1 file changed, 21 insertions(+), 26 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
index f3a3296c811c..800f11b29dcd 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
@@ -37,15 +37,12 @@ properties:
     maxItems: 1
 
   clocks:
-    minItems: 1
+    minItems: 2
     maxItems: 3
 
   clock-names:
-    minItems: 1
-    items:
-      - const: ref
-      - const: ref_aux
-      - const: qref
+    minItems: 2
+    maxItems: 3
 
   power-domains:
     maxItems: 1
@@ -85,22 +82,9 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,msm8998-qmp-ufs-phy
               - qcom,sa8775p-qmp-ufs-phy
               - qcom,sc7280-qmp-ufs-phy
-              - qcom,sm8450-qmp-ufs-phy
-    then:
-      properties:
-        clocks:
-          minItems: 3
-        clock-names:
-          minItems: 3
-
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - qcom,msm8998-qmp-ufs-phy
               - qcom,sc8180x-qmp-ufs-phy
               - qcom,sc8280xp-qmp-ufs-phy
               - qcom,sdm845-qmp-ufs-phy
@@ -111,13 +95,18 @@ allOf:
               - qcom,sm8150-qmp-ufs-phy
               - qcom,sm8250-qmp-ufs-phy
               - qcom,sm8350-qmp-ufs-phy
+              - qcom,sm8450-qmp-ufs-phy
               - qcom,sm8550-qmp-ufs-phy
     then:
       properties:
         clocks:
-          maxItems: 2
+          minItems: 3
+          maxItems: 3
         clock-names:
-          maxItems: 2
+          items:
+            - const: ref
+            - const: ref_aux
+            - const: qref
 
   - if:
       properties:
@@ -128,22 +117,28 @@ allOf:
     then:
       properties:
         clocks:
-          maxItems: 1
+          minItems: 2
+          maxItems: 2
         clock-names:
-          maxItems: 1
+          items:
+            - const: ref
+            - const: qref
 
 additionalProperties: false
 
 examples:
   - |
     #include <dt-bindings/clock/qcom,gcc-sc8280xp.h>
+    #include <dt-bindings/clock/qcom,rpmh.h>
 
     ufs_mem_phy: phy@1d87000 {
         compatible = "qcom,sc8280xp-qmp-ufs-phy";
         reg = <0x01d87000 0x1000>;
 
-        clocks = <&gcc GCC_UFS_REF_CLKREF_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
-        clock-names = "ref", "ref_aux";
+        clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>,
+                 <&gcc GCC_UFS_REF_CLKREF_CLK>;
+
+        clock-names = "ref", "ref_aux", "qref";
 
         power-domains = <&gcc UFS_PHY_GDSC>;
 
-- 
2.25.1


  reply	other threads:[~2023-12-14  9:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14  9:10 [PATCH 00/16] Fix Qcom UFS PHY clocks Manivannan Sadhasivam
2023-12-14  9:10 ` Manivannan Sadhasivam [this message]
2023-12-14 15:55   ` [PATCH 01/16] dt-bindings: phy: qmp-ufs: Fix " Conor Dooley
2023-12-14 17:20   ` Rob Herring
2023-12-18 11:48     ` Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 02/16] phy: qcom-qmp-ufs: Switch to devm_clk_bulk_get_all() API Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 03/16] dt-bindings: clock: qcom: Add missing UFS QREF clocks Manivannan Sadhasivam
2023-12-14 15:44   ` Conor Dooley
2023-12-14  9:10 ` [PATCH 04/16] clk: qcom: gcc-sc8180x: " Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 05/16] arm64: dts: qcom: msm8996: Fix UFS PHY clocks Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 06/16] arm64: dts: qcom: msm8998: " Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 07/16] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 08/16] arm64: dts: qcom: sm6115: " Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 09/16] arm64: dts: qcom: sm6125: " Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 10/16] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 11/16] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 12/16] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 13/16] arm64: dts: qcom: sc8180x: " Manivannan Sadhasivam
2023-12-14  9:10 ` [PATCH 14/16] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2023-12-14  9:11 ` [PATCH 15/16] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2023-12-14  9:11 ` [PATCH 16/16] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
2023-12-14 10:15 ` [PATCH 00/16] Fix Qcom " Johan Hovold
2023-12-14 10:39   ` Manivannan Sadhasivam
2023-12-14 11:00     ` Johan Hovold
2023-12-14 11:14       ` Manivannan Sadhasivam
2023-12-14 11:30         ` Johan Hovold
2023-12-14 11:49           ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231214091101.45713-2-manivannan.sadhasivam@linaro.org \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).