From: Alain Volmat <alain.volmat@foss.st.com>
To: Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Pierre-Yves MORDRET <pierre-yves.mordret@foss.st.com>,
Alain Volmat <alain.volmat@foss.st.com>
Cc: Conor Dooley <conor@kernel.org>, <linux-i2c@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v3 5/9] i2c: stm32f7: perform I2C_ISR read once at beginning of event isr
Date: Fri, 15 Dec 2023 18:06:09 +0100 [thread overview]
Message-ID: <20231215170617.95868-6-alain.volmat@foss.st.com> (raw)
In-Reply-To: <20231215170617.95868-1-alain.volmat@foss.st.com>
Move readl_relaxed of I2C_ISR register at beginning of event isr
so that it done once for both master & slave handling.
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 15100fed0a3f..f7abf6d3a7b9 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1419,15 +1419,13 @@ static bool stm32f7_i2c_is_slave_busy(struct stm32f7_i2c_dev *i2c_dev)
return i == busy;
}
-static irqreturn_t stm32f7_i2c_slave_isr_event(struct stm32f7_i2c_dev *i2c_dev)
+static irqreturn_t stm32f7_i2c_slave_isr_event(struct stm32f7_i2c_dev *i2c_dev, u32 status)
{
void __iomem *base = i2c_dev->base;
- u32 cr2, status, mask;
+ u32 cr2, mask;
u8 val;
int ret;
- status = readl_relaxed(i2c_dev->base + STM32F7_I2C_ISR);
-
/* Slave transmitter mode */
if (status & STM32F7_I2C_ISR_TXIS) {
i2c_slave_event(i2c_dev->slave_running,
@@ -1531,11 +1529,11 @@ static irqreturn_t stm32f7_i2c_isr_event_thread(int irq, void *data)
u32 status, mask;
int ret;
- if (!i2c_dev->master_mode)
- return stm32f7_i2c_slave_isr_event(i2c_dev);
-
status = readl_relaxed(i2c_dev->base + STM32F7_I2C_ISR);
+ if (!i2c_dev->master_mode)
+ return stm32f7_i2c_slave_isr_event(i2c_dev, status);
+
/* NACK received */
if (status & STM32F7_I2C_ISR_NACKF) {
dev_dbg(i2c_dev->dev, "<%s>: Receive NACK (addr %x)\n",
--
2.25.1
next prev parent reply other threads:[~2023-12-15 17:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 17:06 [PATCH v3 0/9] i2c: stm32f7: enhancements and support for stm32mp25 Alain Volmat
2023-12-15 17:06 ` [PATCH v3 1/9] i2c: stm32f7: use dev_err_probe upon calls of devm_request_irq Alain Volmat
2023-12-22 10:44 ` Wolfram Sang
2023-12-15 17:06 ` [PATCH v3 2/9] i2c: stm32f7: perform most of irq job in threaded handler Alain Volmat
2023-12-22 10:44 ` Wolfram Sang
2023-12-15 17:06 ` [PATCH v3 3/9] i2c: stm32f7: simplify status messages in case of errors Alain Volmat
2023-12-22 10:45 ` Wolfram Sang
2023-12-15 17:06 ` [PATCH v3 4/9] dt-bindings: i2c: document st,stm32mp25-i2c compatible Alain Volmat
2023-12-22 10:45 ` Wolfram Sang
2023-12-15 17:06 ` Alain Volmat [this message]
2023-12-22 10:45 ` [PATCH v3 5/9] i2c: stm32f7: perform I2C_ISR read once at beginning of event isr Wolfram Sang
2023-12-15 17:06 ` [PATCH v3 6/9] i2c: stm32f7: add support for stm32mp25 soc Alain Volmat
2023-12-22 10:45 ` Wolfram Sang
2023-12-15 17:06 ` [PATCH v3 7/9] arm64: dts: st: add all 8 i2c nodes on stm32mp251 Alain Volmat
2023-12-15 17:06 ` [PATCH v3 8/9] arm64: dts: st: add i2c2/i2c8 pins for stm32mp25 Alain Volmat
2023-12-15 17:06 ` [PATCH v3 9/9] arm64: dts: st: add i2c2 / i2c8 properties on stm32mp257f-ev1 Alain Volmat
2024-04-25 8:00 ` [PATCH v3 0/9] i2c: stm32f7: enhancements and support for stm32mp25 Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215170617.95868-6-alain.volmat@foss.st.com \
--to=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@foss.st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).